Merged
Conversation
This is technically not needed, but CodeQL thinks those variables are client provided Strings, since one code path leads to the InitFilter. We do it anyway to fix 3 alerts + its trivial.
CodeQL doesn't understand validation which is happening *after* Files or Paths are created. Rewriting the method a little bit solves that + its now using Path instead of File.
…stream transferTo() shortcut.
this requires unfortunately another config file since path settings can't be set in the workflow config. see github/codeql-action#283
snoopdave
approved these changes
Sep 11, 2021
Contributor
snoopdave
left a comment
There was a problem hiding this comment.
Some very nice simplifications and fixes in here!
Member
Author
|
@snoopdave thanks for taking a look. As mentioned in the PR I just manually closed the two additional CodeQL alerts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes some (~14) CodeQL alerts.
Most of them could be fixed by restructuring the code a little.
75ba795 changes the config so that JS alerts don't show up three times.
I am thinking about closing two additional alerts manually:
bonus:
96810ea is a unrelated fix, 188e201 sets JS produced cookies to https and "SameSite" by default