[feat][pip] PIP-454: Metadata Store Migration Framework#25196
Merged
merlimat merged 2 commits intoapache:masterfrom Feb 25, 2026
Merged
[feat][pip] PIP-454: Metadata Store Migration Framework#25196merlimat merged 2 commits intoapache:masterfrom
merlimat merged 2 commits intoapache:masterfrom
Conversation
lhotari
reviewed
Jan 30, 2026
lhotari
reviewed
Jan 30, 2026
lhotari
approved these changes
Jan 30, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM, just a few comments / questions.
eolivelli
reviewed
Feb 3, 2026
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
A couple of questions:
- is it possible to also migrate back from Oxia to ZooKeeper ?
- this PIP is not about the metadata store to coordinate geo replication, should we state it explicitly ?
Contributor
Author
|
Good questions.
While the mechanism can be quite generic, the tricky part to make it work seamlessly is to carry over the same version ids on each metadata record. That allows brokers and bookies conditional writes to not fail in the migration. In Oxia we were able to add explicit override for this specific purpose. With ZK it's unfortunately not as easy.
Good point. I'll highlight this more. |
dao-jun
approved these changes
Feb 6, 2026
mattisonchao
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: