Fix invalid memory access on the first pending batch receive callback#441
Merged
BewareMyPower merged 1 commit intoapache:mainfrom Aug 21, 2024
Merged
Conversation
Contributor
Author
|
This is an example crash frame in production: |
lhotari
approved these changes
Aug 21, 2024
Member
lhotari
left a comment
There was a problem hiding this comment.
LGTM. Good work @BewareMyPower
shibd
pushed a commit
to shibd/pulsar-client-cpp
that referenced
this pull request
Aug 21, 2024
…apache#441) (cherry picked from commit 2ec734b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-client-cpp/lib/ConsumerImplBase.cc
Lines 109 to 112 in 5940cb5
In the code above,
batchReceiveis a reference to the first element in the queue (batchPendingReceives_). Afterpop(), the memory would be invalid to access, which might cause unexpected crash.Modifications
Add a
popBatchReceiveCallbackmethod that moves the callback from the first element inbatchPendingReceives_. Use this method to replace error-pronefront()-pop()calls.