Skip to content

Conversation

@SourceR85
Copy link
Contributor

This removes "clone-buffer" dependency.

Since Buffer.from is stable, there is no need for it.

@janl
Copy link
Member

janl commented Jun 18, 2024

small point, but should we maybe replace all instances of this with Buffer.from() just to remove one level of indirection

@SourceR85
Copy link
Contributor Author

SourceR85 commented Jun 18, 2024

small point, but should we maybe replace all instances of this with Buffer.from() just to remove one level of indirection

This will break pouchdb-utils/clone.js in browser engines.
cloneBinaryObject-browser.js is import-mapped to cloneBinaryObject.js, 'cause Buffer is a Node.js specific API.

If we want to unify it, we have to refactor towards ES standard ArrayBuffer/TypedArrays.
(shouldn't be part of this PR)

@janl
Copy link
Member

janl commented Jun 18, 2024

oops, makes sense!

@SourceR85 SourceR85 merged commit c7c8afb into apache:master Jun 18, 2024
@SourceR85 SourceR85 deleted the remove-clone-buffer branch June 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants