Skip to content

Conversation

@SourceR85
Copy link
Contributor

@SourceR85 SourceR85 commented Apr 2, 2024

This refactors dbFetch into an async function.
Instead of anonymous objects, instances of PouchError are now thrown.

Additional changes:

  • update var to const.
  • avoid setting "Content-Type" request header for getIndexes and deleteIndex.

I isolated this PR from #8860, because it includes type change of exceptions.

NOTE: Can't check for instanceof PouchError.
Class PouchError isn't exported, left a hints as FIXME in tests.

@SourceR85 SourceR85 changed the title Update PouchDB-find adapters/http chore: PouchDB-find adapters/http update Apr 3, 2024
@SourceR85 SourceR85 marked this pull request as draft April 3, 2024 04:20
@SourceR85 SourceR85 marked this pull request as ready for review April 3, 2024 05:38
@SourceR85 SourceR85 merged commit d301495 into apache:master Apr 3, 2024
@SourceR85 SourceR85 deleted the find-http-adapters-promise branch April 3, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants