samv7: fix printf warnings in QSPI#8613
Merged
Merged
Conversation
1d62d8c to
63b28c5
Compare
xiaoxiang781216
approved these changes
Feb 21, 2023
Contributor
|
Let's ignore the ci broken which is fixed by #8611 and merge this simple change. |
| uint32_t regval; | ||
|
|
||
| spiinfo("frequency=%d\n", frequency); | ||
| spiinfo("frequency=%"PRId32"\n", frequency); |
Contributor
There was a problem hiding this comment.
PRIu32 would be a better candidate for unsigned types.
Contributor
Author
There was a problem hiding this comment.
You are correct. I replaced it to be the same as so far, only to fix the warning. Let me modify that. It should be short patch again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.