usrsock: Do not return error when conn not found for an event#8609
Merged
Conversation
We never check its result and assume it will success, so an assert should be better than retval. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
There might be some cases that we receive an event after socket is closed because of out-of-ordered rpmsg, since it may not cause problem, we may omit the error. Also change log level to err when returning negated errno, because if we return negated errno, we'll directly trigger RPMSG_ASSERT outside, so we need at least an error message to indicate the reason. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
xiaoxiang781216
approved these changes
Feb 21, 2023
Contributor
|
Let's ignore the ci broken which is fixed by #8611 and merge this simple change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When rpmsg is in heavy load(e.g. rpmsgfs), it may result in out-of-ordered messages because it can trigger another callback in rpmsg_send. Then client side of usrsock may receive an event after socket is closed (e.g. SENDTO_READY event in UDP connect). Normally just drop these events might be acceptable, but we're returning error now, and triggers RPMSG_ASSERT outside.
Patches included:
Impact
Testing
CI & Vela