Master pr nxstyle improvments by davids5 · Pull Request #2 · apache/nuttx

davids5 · 2019-12-22T19:47:43Z

This will get us off the ground on the formatting tool we can get in to the workfow.

We are going to need your expertise on the the makefile side. (be nice i got it to work ;)

There should be no formatting check changes - it just get us a tool that will work with compiler aware ide/editors.

make check_format - will check all the files that differ from master

tools/check_code_style.sh file name will check a file

patacongo · 2019-12-22T22:42:32Z

I added Xiao Xiang to the reviewers. We need to have a lot of concurrence here since this PR implements a portion of the workflow while there no workflow requirements in place. I think this piece of the workflow is not so controversial, but I would like to have Xiang provide his input as well. Xiang is the most authorative person on the build system and must be in the loop on build system changes.

patacongo · 2019-12-23T00:36:29Z

What is this? How did I do this? What does closed mean? Is that like declined? What was closed?
Do I need to unclose something?
...
Okay I found the button that I must have pushed. Reopened.

Ouss4 · 2019-12-23T00:48:17Z

Yes close without merging is like decline.
It's still closed btw.

==2117790==ERROR: AddressSanitizer: global-buffer-overflow on address 0x64d9e3c0 at pc 0x59ac4e16 bp 0xcefe8058 sp 0xcefe8048 READ of size 1 at 0x64d9e3c0 thread T0 #0 0x59ac4e15 in up_nputs sim/up_nputs.c:54 #1 0x59a67e4c in syslog_default_write syslog/syslog_channel.c:220 #2 0x59a67823 in syslog_default_write syslog/syslog_write.c:101 #3 0x59a67f10 in syslog_write syslog/syslog_write.c:153 #4 0x59a651c3 in syslogstream_flush syslog/syslog_stream.c:60 #5 0x59a6564e in syslogstream_addchar syslog/syslog_stream.c:104 #6 0x59a6576f in syslogstream_putc syslog/syslog_stream.c:140 #7 0x5989fc4d in vsprintf_internal stdio/lib_libvsprintf.c:952 #8 0x598a1298 in lib_vsprintf stdio/lib_libvsprintf.c:1379 #9 0x59a64ea4 in nx_vsyslog syslog/vsyslog.c:223 #10 0x598a601a in vsyslog syslog/lib_syslog.c:68 #11 0x59b0e3dc in AIOTJS::logPrintf(int, char const*, ...) src/ajs_log.cpp:45 #12 0x59b03d56 in jse_dump_obj src/jse/quickjs/jse_quickjs.cpp:569 #13 0x59b03ea1 in jse_dump_error1(JSContext*, unsigned long long) src/jse/quickjs/jse_quickjs.cpp:602 #14 0x59b03dd9 in jse_dump_error(JSContext*) src/jse/quickjs/jse_quickjs.cpp:591 #15 0x59bed615 in ferry::DomComponent::callHook(char const*) src/framework/dom/component.cpp:65 #16 0x59bfe0ff in ferry::DomComponent::initialize() src/framework/dom/component.cpp:645 #17 0x59bb141d in dom_create_component(JSContext*, unsigned long long, unsigned long long, unsigned long long) (/home/wangbowen/project/central/vela_miot_bes_m0/bin/audio+0x365c41d) #18 0x59b4c0d3 in AIOTJS::__createComponent(JSContext*, unsigned long long, int, unsigned long long*) (/home/wangbowen/project/central/vela_miot_bes_m0/bin/audio+0x35f70d3) #19 0x5a56ec17 in js_call_c_function quickjs/quickjs.c:16108 Signed-off-by: wangbowen6 <wangbowen6@xiaomi.com>

davids5 requested review from acassis and patacongo December 22, 2019 19:50

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c

davids5 requested review from Ouss4 and patacongo December 22, 2019 19:52

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

davids5 commented Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

Comment thread tools/nxstyle.c Outdated

Ouss4 reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/Makefile.unix

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

davids5 commented Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

davids5 commented Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

davids5 commented Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c Outdated

Comment thread tools/nxstyle.c Outdated

Comment thread tools/nxstyle.c Outdated

Comment thread tools/nxstyle.c Outdated

Comment thread tools/nxstyle.c Outdated

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/Makefile.unix

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/Makefile.unix

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/check_code_style.sh

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/check_code_style.sh

davids5 force-pushed the master-pr-nxstyle-improvments branch from 6d3e8fc to 17d05b6 Compare December 22, 2019 20:41

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/nxstyle.c

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/Makefile.unix

patacongo requested a review from xiaoxiang781216 December 22, 2019 22:30

patacongo reviewed Dec 22, 2019

View reviewed changes

Comment thread tools/check_code_style.sh

patacongo closed this Dec 22, 2019

anchao mentioned this pull request Oct 25, 2022

arm/armv6-m: fix build break if enable syntax unified #7422

Merged

GUIDINGLI mentioned this pull request Feb 10, 2023

sim: fix vfork report error #8497

Merged

pussuw mentioned this pull request Feb 21, 2023

signal/sig_dispatch: Fix case where signal action is sent twice #8605

Merged

anchao mentioned this pull request May 8, 2023

libc/qsort: fix invalid-pointer-pair if enable detect_invalid_pointer_pairs=2 #9207

Merged

zhhyu7 mentioned this pull request Jul 17, 2023

net/local: remove client from server.lc_waiters when client close #9841

Merged

GUIDINGLI mentioned this pull request Sep 23, 2023

local socket: fix accept used after free #10785

Merged

nuttxs mentioned this pull request Oct 10, 2023

Fix the os halt issue when esp32s3 wlan has high-speed or long time d… #10882

Merged

This was referenced Aug 19, 2024

nuttx/note:fix runtime error. #12984

Closed

nuttx/sim:By default, stack-use-after-return is not checked when enabling SIM_ASAN. #12989

Merged

nuttx/sim:By default, stack-use-after-return is not checked when enabling SIM_ASAN. #13043

Merged

anchao mentioned this pull request Sep 24, 2024

arch/tricore: fix build error on tricore #13593

Merged

jasonbu mentioned this pull request Sep 27, 2024

procfs:fix cat dir cause crash #13676

Merged

GUIDINGLI mentioned this pull request Oct 11, 2024

Fix system crash when set CONFIG_PRIORITY_INHERITANCE=y #14108

Merged

yintao707 mentioned this pull request Oct 11, 2024

rpmsg_sockif: add some modifaction for rpsocket #14118

Merged

CV-Bowen mentioned this pull request Oct 15, 2024

vsprintf:fix bug when print int64 0x8000000000000000 #14279

Merged

hiccupzhu mentioned this pull request Oct 16, 2024

sim/alsa: fix runtime warning. #14344

Merged

zhhyu7 mentioned this pull request Oct 29, 2024

arp.h: make struct arpreq four-byte aligned #14535

Merged

hujun260 mentioned this pull request Nov 1, 2024

remove up_cpu_pause up_cpu_resume up_cpu_paused up_cpu_pausereq #13863

Merged

lipengfei28 mentioned this pull request Nov 12, 2024

arch/arm64: bug fix,arm64_fatal_handler need regs parms #14730

Merged

blacksun-V mentioned this pull request Nov 20, 2024

[HELP] <title> arch/arm/src/armv6-m/arm_svcall.c There seems to be a problem #14862

Closed

1 task

jerpelea mentioned this pull request Dec 27, 2024

{bp-15294} arch/risc-v/espressif: add missing spinlock to wlan_recvframe #15364

Merged

simbit18 mentioned this pull request Jan 29, 2025

[BUG] Make: sim:quickjs fails to build #15712

Closed

1 task

W-M-R mentioned this pull request Jul 11, 2025

toolchain/arm: Fix crash caused by clang compiling with -mfpu=fpv5-d16 and -march=armv8.1-m.main+mve.fp+fp.dp #16711

Merged

husong2 mentioned this pull request Nov 29, 2025

sched/group: move task group into task_tcb_s to improve performance #11832

Merged

This was referenced Dec 23, 2025

driver/note: make SIZEOF_NOTE_START return the right size #17557

Merged

fs/romfs: revert the romfs write feature #17488

Merged

pangzhen1xiaomi mentioned this pull request Jan 26, 2026

sched/wqueue: add configuring the stack of an hpwork/lpwork as static #18072

Merged

hujun260 mentioned this pull request Jan 29, 2026

sched: Consolidate return statements in sched_critmonitor() for MISRA HIS compliance #18237

Merged

aviralgarg05 mentioned this pull request Feb 11, 2026

[Discussion][GSoC 2026] Create a NuttX Distribution with Dynamic Binary (ELF) Loading (350h) #18380

Open

1 task

Conversation

davids5 commented Dec 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patacongo commented Dec 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patacongo commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ouss4 commented Dec 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davids5 commented Dec 22, 2019 •

edited

Loading

patacongo commented Dec 22, 2019 •

edited

Loading

patacongo commented Dec 23, 2019 •

edited

Loading