Revert "sem: change sem wait to atomic operation"#14804
Merged
Conversation
This reverts commit befe298. Because a few regressions have been reported and it likely will take some time to fix them: * for some configurations, semaphore can be used on the special memory region, where atomic access is not available. cf. apache#14625 * include/nuttx/lib/stdatomic.h is not compatible with the C11 semantics, which the change in question relies on. cf. apache#14755
|
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing:
To make this PR compliant, the author should:
By addressing these points, the PR will be more complete, easier to review, and better aligned with the NuttX contribution guidelines. |
Contributor
Author
|
@xiaoxiang781216 |
xiaoxiang781216
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit befe298.
Because a few regressions have been reported and
it likely will take some time to fix them:
for some configurations, semaphore can be used on the special memory region, where atomic access is not available. cf. sched/semaphore: change semcount type to int #14625
include/nuttx/lib/stdatomic.h is not compatible with the C11 semantics, which the change in question relies on. cf. semaphore: Fix a few regressions #14755
Impact
Testing
tested with esp32s3-devkit:smp ostest