Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix#14761
Merged
Conversation
|
[Experimental Bot, please feedback here] No. The PR is missing critical information required by the NuttX template.
Therefore, the PR in its current state does not meet the NuttX requirements. It needs substantial additions to be considered complete. |
pussuw
reviewed
Nov 13, 2024
pussuw
approved these changes
Nov 13, 2024
Contributor
pussuw
left a comment
There was a problem hiding this comment.
LGTM. This also fixes recursive panic/assertion for me when trying to take the spinlock from assert!
anchao
reviewed
Nov 13, 2024
anchao
reviewed
Nov 13, 2024
…ction" This reverts commit 35240d7.
623ca36 to
f4c9338
Compare
pussuw
approved these changes
Nov 15, 2024
jerpelea
approved these changes
Nov 15, 2024
xiaoxiang781216
approved these changes
Nov 15, 2024
Contributor
|
@yamt please fix the following warning: |
Note that SYSLOG_DEFAULT can be used in extreme situations, including very early in the boot.
xiaoxiang781216
approved these changes
Nov 18, 2024
Closed
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix.
original change #14722
a revert #14751
Impact
Testing
(with semaphore: Fix a few regressions #14755 and a few other unrelated local patches)