Skip to content

arch: support customized up_cpu_index() in AMP mode#13940

Closed
fxysunshine wants to merge 1 commit into
apache:masterfrom
fxysunshine:sched_irq_1008
Closed

arch: support customized up_cpu_index() in AMP mode#13940
fxysunshine wants to merge 1 commit into
apache:masterfrom
fxysunshine:sched_irq_1008

Conversation

@fxysunshine
Copy link
Copy Markdown
Contributor

Summary

Some app with same code runs on different cores in AMP mode, need know the physical core on which the function is called.
To support customized up_cpu_index().

Impact

There is no impact for SMP up_cpu_index(), and AMP in default.

Testing

a customed armv7m board in vela

Some app with same code runs on different cores in AMP mode,
need the physical core on which the function is called.

Signed-off-by: fangxinyong <fangxinyong@xiaomi.com>
@github-actions github-actions Bot added Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small labels Oct 8, 2024
@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Oct 8, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Why is this change necessary? What problem does it solve?
    • What functional part of the code is being changed? Be specific (e.g., "the up_cpu_index() function in sched/core/sched_getcpu.c").
    • How does the customized up_cpu_index() work? What mechanism is used to determine the physical core?
  • Impact:
    • You state "There is no impact for SMP ... and AMP in default." This is not sufficient.
      • Even if there is no impact in most cases, you need to explicitly confirm this for each category (user, build, hardware, documentation, security, compatibility) and explain why.
      • For example, "Impact on build: NO, this change only affects runtime behavior."
    • "Anything else to consider?" This section is for truly exceptional impacts that don't fit the other categories. Don't use it as a catch-all. Be specific about any potential concerns.
  • Testing:
    • Insufficient detail. Provide:
      • Specific host OS and version: (e.g., "Ubuntu 20.04")
      • Compiler version: (e.g., "GCC 10.3.0")
      • Target architecture and board: (e.g., "ARMv7-M, STM32F4 Discovery board")
      • NuttX configuration: (Important! Which config file did you use?)
    • Meaningful test logs:
      • The logs should demonstrate:
        • The problem that existed before your change.
        • How your change fixes the problem.
      • Don't just provide raw logs. Add comments and explanations to highlight the relevant parts.

Recommendations:

  1. Provide the missing information as described above.
  2. Consider providing code snippets to illustrate the changes you've made. This will make your PR much easier to review.
  3. Review the NuttX contribution guidelines: Make sure you are familiar with all the requirements.

A well-written PR that follows the guidelines is more likely to be reviewed and merged quickly.

@xiaoxiang781216
Copy link
Copy Markdown
Contributor

@fxysunshine dup with #13886

@fxysunshine fxysunshine marked this pull request as draft October 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: arm Issues related to ARM (32-bit) architecture Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants