esp32s3: Fix faulty esp32s3-devkit:stack example#13563
Merged
xiaoxiang781216 merged 1 commit intoSep 21, 2024
Merged
Conversation
This defconfig is an example of the recorded stack and it became faulty recently after the implementation of the `up_current_regs` functions. The `noinstrument_function` directive must be used for preventing it from being looped when instrumentation is enabled. Also, this commit places `sched/instrument/stack_record.c` in IRAM.
xiaoxiang781216
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Task ID: _ NUT-1183_
Summary
esp32s3-devkit:stackexampleThis defconfig is an example of the recorded stack and it became faulty recently after the implementation of the
up_current_regsfunctions (#13423). Thenoinstrument_functiondirective must be used to prevent it from being looped when instrumentation is enabled. Also, this commit placessched/instrument/stack_record.cin IRAM.Impact
Make
esp32s3-devkit:stackexample work again.Testing
Internal CI testing + ESP32-S3-DevKitC-1 v1.0
Just build it and run
cat /proc/0/stack.