serial/pci_16550: make sure that interrupts are disabled during init#13509
Merged
Conversation
acassis
approved these changes
Sep 17, 2024
Member
|
[Experimental Bot, please feedback here] This Pull Request appears to partially meet the NuttX requirements. Here's a breakdown: Strengths:
Areas for Improvement:
Example for "Impact" Section: Recommendations:
By providing a comprehensive and well-documented PR, you increase the chances of your contribution being reviewed and merged quickly. |
Make sure that interrups are disabled during initialization. This is a proper fix for an unexpected MSI interrupt for PCI serial driver. Signed-off-by: p-szafonimateusz <p-szafonimateusz@xiaomi.com>
c99233a to
a42fa51
Compare
xiaoxiang781216
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make sure that interrups are disabled during initialization.
This is a proper fix for an unexpected MSI interrupt for PCI serial driver.
Impact
Testing
intel64 hw