arch: inline up_testset in arm arm64 riscv xtensa#12961
Merged
Conversation
anchao
approved these changes
Aug 18, 2024
xiaoxiang781216
approved these changes
Aug 18, 2024
7d35ebd to
cc00435
Compare
test: Configuring NuttX and compile: $ ./tools/configure.sh -l qemu-armv8a:nsh_smp $ make Running with qemu $ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic \ -machine virt,virtualization=on,gic-version=3 \ -net none -chardev stdio,id=con,mux=on -serial chardev:con \ -mon chardev=con,mode=readline -kernel ./nuttx Signed-off-by: hujun5 <hujun5@xiaomi.com>
| && !defined(CONFIG_ARCH_CHIP_LC823450) \ | ||
| && !defined(CONFIG_ARCH_CHIP_CXD56XX) \ | ||
| && !defined(CONFIG_ARCH_CHIP_RP2040) | ||
| static inline_function spinlock_t up_testset(FAR volatile spinlock_t *lock) |
Contributor
There was a problem hiding this comment.
We do not need FAR for arm
| typedef uint64_t spinlock_t; | ||
|
|
||
| #if defined(CONFIG_ARCH_HAVE_TESTSET) | ||
| static inline_function spinlock_t up_testset(FAR volatile spinlock_t *lock) |
Contributor
There was a problem hiding this comment.
We do not need FAR for arm
| ****************************************************************************/ | ||
|
|
||
| #if defined(CONFIG_ARCH_RV_ISA_A) | ||
| static inline_function spinlock_t up_testset(FAR volatile spinlock_t *lock) |
Contributor
There was a problem hiding this comment.
We do not need FAR for RV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inline up_testset in arm arm64 riscv xtensa
Impact
Testing
Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx
ostest