Skip to content

build.yml: Brought into sync with NuttX repository#3031

Merged
lupyuen merged 1 commit into
apache:masterfrom
simbit18:simbit18-jobmsvc
Mar 20, 2025
Merged

build.yml: Brought into sync with NuttX repository#3031
lupyuen merged 1 commit into
apache:masterfrom
simbit18:simbit18-jobmsvc

Conversation

@simbit18
Copy link
Copy Markdown
Contributor

@simbit18 simbit18 commented Mar 19, 2025

Summary

msvc job is missing brought into sync with nuttx repository

added:

Impact

Impact on user: NO.

Impact on build: NO.

Impact on hardware: NO

Impact on documentation: NO

Impact on security: NO

Impact on compatibility: NO

Testing

CI

@nuttxpr
Copy link
Copy Markdown

nuttxpr commented Mar 19, 2025

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements, although the testing section could be improved.

While it mentions CI, it lacks specific details about the build hosts and targets tested. Simply stating "CI" isn't sufficient. It should list the specific CI environments used (e.g., GitHub Actions runners) and specify the architectures and configurations tested within those environments. Ideally, it would include snippets of successful CI logs demonstrating the relevant changes working as expected. The "Testing logs before change" and "Testing logs after change" sections are empty, which is also a weakness.

@simbit18
Copy link
Copy Markdown
Contributor Author

Sorry @lupyuen @xiaoxiang781216 @raiden00pl @acassis @cederom @hartmannathan could you please see this PR ?

Comment thread .github/workflows/build.yml Outdated
Copy link
Copy Markdown
Member

@lupyuen lupyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, sorry I should have synced this earlier :-)

added
    CI: Kill CI Test after 2 hours
    see apache/nuttx#14849

    job msvc Windows native
    see
    apache/nuttx#13894
    apache/nuttx#15989

Signed-off-by: simbit18 <simbit18@gmail.com>
Copy link
Copy Markdown
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @simbit18 :-)

@lupyuen lupyuen merged commit 95c99d9 into apache:master Mar 20, 2025
@simbit18 simbit18 deleted the simbit18-jobmsvc branch March 21, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants