Feature/add debug info#2911
Merged
xiaoxiang781216 merged 2 commits intoDec 21, 2024
Merged
Conversation
|
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. Yes, this PR appears to meet the basic NuttX requirements, but is missing some crucial information. Here's a breakdown of what's good and what needs improvement: Strengths:
Weaknesses:
In short: The PR description is a good starting point, but needs significantly more detail in the Impact and Testing sections to be considered complete and ready for review. Providing concrete examples and justifications for each point will greatly increase the likelihood of quick and positive feedback. |
ce5c502 to
b74d82b
Compare
cederom
approved these changes
Dec 20, 2024
Contributor
cederom
left a comment
There was a problem hiding this comment.
Thank you @eren-terzioglu :-)
xiaoxiang781216
approved these changes
Dec 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to apache/nuttx#15304
Add debug_info target support to parse and print
sysinfo.hfile which is output file of nxdiag application without flashing it to the device or even enablingSYSTEM_NXDIAGoption. We can use this feature to have more information about user system environment when we are investigating issue. Users only need to run make debug_info on their problematic code.Impact
Common layer change
Testing
esp32c6-devkitc:nshconfig selected and then runmake debug_infocommand