Upgrade Gradle Tooling API 9.3.0-rc-2 #9112
Conversation
| this.value = value; | ||
| this.name = propertyName; | ||
| } | ||
| public static final record Property(Object id, String scope, String name, PropertyKind kind, String type, String value) { |
There was a problem hiding this comment.
nit: records are implicitly final and static
There was a problem hiding this comment.
Oh. I left that change unintentionally there. I just needed a quick and good toString() method for debugging.
Well, if it made there let's keep that, I'll just remove the static final in the upcoming commit.
There was a problem hiding this comment.
its something we could also add as editor hint. I put it on my TODO list ;)
|
found this in my stash as leftover of #8814 which might be needed on newer gradle versions: diff --git a/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle b/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle
index ef7b070ca4..0eff699006 100644
--- a/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle
+++ b/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle
@@ -31,7 +31,7 @@ java {
}
task testJar(type: Jar) {
- classifier = 'tests'
+ archiveClassifier = 'tests'
from sourceSets.test.output
} |
|
The |
it's tests are known to be unreliable. Might be just bad luck and we have to restart it a few times more. btw if you want that CI is running the gradle tests on JDK 25 too, all you have to do is remove the if-conditions at netbeans/.github/workflows/main.yml Line 943 in 57fc9ac (the other gradle modules are right below) |
Need a bit more than that, though I have that change ready to commit. |
|
LSP test is now green |
|
This one is ready for review, keeping #9125 in mind. |
|
Thanks for looking at this. My one question would be whether there is a particular reason to choose a release candidate over |
Well, this upgrade was not that easy as I thought would be. Mostly due to the Micronaut based test projects were too old to work with Gradle 9, and when I upgraded the Micronaut plugin version some tests needed some adjustments as well.
During testing I've found some API design issues, those would be addressed later (if ever).
I think there are some Micronaut mines still out there, so I mark this one Draft till I can cover those.