Updated issue templates for NB 25 rc phase + update PR template

[mbien]

• added number prefixes for ordering purposes (issue templates, discussion links etc)
• added merge/approval checklist to PR template

see below

---

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

[neilcsmith-net]

Generally looks good. Please check config.yml.

[neilcsmith-net]

I'm not sure we should be changing the name of this file! https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

[mbien]

will revert it back. This means the links will appear at random positions?

[mbien]

it probably will append it to the bottom. reverted

[mbien]

just noticed that the checkboxes will be visible as tasks on the PR:

not sure if we want this

[mbien]

we could wrap it in a details section but leave it open by default?

[matthiasblaesing]

Only the PR change part: I don't think this will help. People that actually read the text already now the part, because they already know it. At least once it was said that the bottom part of the PR should be removed and I agree with that, it should not be part of history or change log.

[mbien]

Only the PR change part: I don't think this will help

I am also not sure if this will help but I am out of ideas. The discussion on the mailing list transpired that it might help to have something what reminds devs about those things. I don't see how we can automate this, so lets give the template a try - other apache projects do have this too (example).

I had enough of having to keep linking the reviewer guide etc - it feels stupid to have to chase after committers and to have to do things like this.

At least once it was said that the bottom part of the PR should be removed and I agree with that, it should not be part of history or change log.

well. I typically remove it too on my PRs. There are also tricks to open PRs without template, so power users can get a clean slate if they want. This is intended for those who commit once per release or less - or those who keep forgetting how delivery works.

the collapsible section can be also set to auto collapse by manually removing the open from <details open>, this would add another method to de-noise the PR text as middle ground - if you don't want to remove the whole thing.

[mbien]

ok lets give this a try. Experienced committers can remove the text or open PRs without a template - same as today. There is also the option to collapse the section by removing the open from <details open> as middle ground. Those who don't commit often or find the check list useful can use it as reminder.

edit: also worth mentioning that we got at least two requests for this from PMCs