Skip to content

fix images for quickstart_platform tutorial#648

Merged
ebarboni merged 1 commit intoapache:masterfrom
ebarboni:master
Mar 9, 2023
Merged

fix images for quickstart_platform tutorial#648
ebarboni merged 1 commit intoapache:masterfrom
ebarboni:master

Conversation

@ebarboni
Copy link
Contributor

@ebarboni ebarboni commented Mar 8, 2023

recovered image from commit 023d7dad4edf5981e76857efcbe98e486a093691

renamed with prefix without version.
removed former platform 73 (they are also in old content)

@ebarboni ebarboni requested a review from mbien March 8, 2023 12:13
@mbien
Copy link
Member

mbien commented Mar 8, 2023

i am a bit confused what is happening here ;/

for example, you removed:
https://github.com/apache/netbeans-website/blob/f03ab9809fab1bf7755ab9b92ef37615ca973793/netbeans.apache.org/src/content/tutorials/images/quickstart-platform_73_new-api-1.png

and added:
https://github.com/apache/netbeans-website/blob/10170847062a64cb7024556aeb0ca97198a72c24/netbeans.apache.org/src/content/tutorials/images/quickstart_platform_new-api-1.png

the first one looks to be properly sized, which probably means that it is more recent?

can't we just keep the images and fix the links?

@mbien
Copy link
Member

mbien commented Mar 8, 2023

but tbh maybe thats how it is supposed to be? Can we test this somehow if everything works before merging?

@ebarboni
Copy link
Contributor Author

ebarboni commented Mar 8, 2023

sorry I had to force push. I was using a bad clone with wrong file name.
https://github.com/apache/netbeans-website/blob/6720139f8c15a51068be35636a7bb617e5a5141f/netbeans.apache.org/src/content/tutorials/nbm-quick-start.adoc may give a preview.
this is intended to respect addition #500

@mbien
Copy link
Member

mbien commented Mar 8, 2023

seems to work now. Although some pictures are too large for their purpose.

i believe what happened that the repo had two kinds of screenshots: the original with the whole component and then smaller versions which showed only a small part of it, this explains:
#648 (comment)

this PR uses the full version of the screenshots now, which is better than nothing but looks a bit ugly sometimes e.g:
https://github.com/apache/netbeans-website/blob/6720139f8c15a51068be35636a7bb617e5a5141f/netbeans.apache.org/src/content/tutorials/nbm-quick-start.adoc#create-the-module

@ebarboni
Copy link
Contributor Author

ebarboni commented Mar 9, 2023

inclined to merge and let "photoshop" expert crop :D. There is no tools to "automate" screen shot ? Would be more deterministic.

@mbien
Copy link
Member

mbien commented Mar 9, 2023

what if we leave the small pictures in the repo? so that someone could rename/switch to them on a case by case basis?

@ebarboni
Copy link
Contributor Author

ebarboni commented Mar 9, 2023

they are in the repo at
https://github.com/apache/netbeans-website/tree/master/netbeans.apache.org/src/old_content/content/tutorials/80/images
and maybe others version.
https://netbeans.apache.org/tutorials/80/nbm-quick-start.html the previous one ( from version 8.0)

I think #500 was also adding new screenshot/content
but the screenshot are missing from ages in the "main" tuto track.

I have not webarchive with valid screen on it.

https://web.archive.org/web/20210518050646/https://netbeans.apache.org/tutorials/nbm-quick-start.html

@mbien
Copy link
Member

mbien commented Mar 9, 2023

oh wow, didn't know that there is another copy of them in the repo - excellent lets merge :)

@ebarboni ebarboni merged commit 434c0b6 into apache:master Mar 9, 2023
@mbien
Copy link
Member

mbien commented Mar 9, 2023

the tutorial has now gigantic windows :)
https://netbeans.apache.org/tutorials/nbm-quick-start.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants