Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@haojin2
Copy link
Contributor

@haojin2 haojin2 commented Oct 11, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Necessary infrastructures
  • Support for boolean sum
  • Unit test coverage

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 added the Numpy label Oct 11, 2019
@haojin2 haojin2 requested a review from reminisce October 11, 2019 08:21
@haojin2 haojin2 self-assigned this Oct 11, 2019
@haojin2 haojin2 requested a review from szha as a code owner October 11, 2019 19:55
@haojin2 haojin2 force-pushed the np_sum_boolean branch 7 times, most recently from ace5750 to 3a1ac00 Compare October 14, 2019 04:56
@haojin2 haojin2 force-pushed the np_sum_boolean branch 4 times, most recently from 45eb531 to b48cab1 Compare October 15, 2019 18:30
@reminisce
Copy link
Contributor

dist-kvstore tests GPU failure has shown up in quite a few PRs recently. Wonder what's the root cause.

@haojin2 haojin2 force-pushed the np_sum_boolean branch 2 times, most recently from 8ea3f84 to c2146c3 Compare October 18, 2019 21:36
@reminisce reminisce merged commit cdfaf39 into apache:master Oct 20, 2019
@haojin2 haojin2 deleted the np_sum_boolean branch October 20, 2019 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants