Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Comparison ops implemented using mshadow #16414

Merged
haojin2 merged 20 commits into from
Oct 14, 2019
Merged

Comparison ops implemented using mshadow #16414

haojin2 merged 20 commits into from
Oct 14, 2019

Conversation

@reminisce
Copy link
Contributor

@reminisce reminisce commented Oct 9, 2019 •
edited
Loading

Description

This PR implemented comparison operators introduced in #15940 to complement the implementation without relying on TVM. This implementation will be included in 1.6 release.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@reminisce reminisce requested a review from szha as a code owner October 9, 2019 22:28
@reminisce reminisce changed the title Comparison ops implemented without TVM Comparison ops implemented using mshadow Oct 9, 2019
@reminisce reminisce added the Numpy label Oct 9, 2019
@reminisce reminisce force-pushed the comp_ops_mshadow_kernel branch from f52ddb8 to 77d7b55 Compare October 10, 2019 05:53
@reminisce reminisce mentioned this pull request Oct 11, 2019
Closed
@reminisce reminisce force-pushed the comp_ops_mshadow_kernel branch from da5c5c7 to af94bad Compare October 11, 2019 21:34
@reminisce reminisce mentioned this pull request Oct 12, 2019
Closed
@reminisce reminisce force-pushed the comp_ops_mshadow_kernel branch from e352cf6 to 5f08bba Compare October 13, 2019 21:51
haojin2
haojin2 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 6d6e46b into apache:master Oct 14, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
@reminisce @aaronmarkham
Comparison ops implemented using mshadow (apache#16414)
a3cdbac 
* boolean op without tvm working

* Fix astype for boolean arrays

* More tests

* Revert

* Fix

* Fix preprocessor in .cu

* Fix logical_not

* Print compilation flags

* Fix transpose taking negative indices

* Fix transpose negative axes

* Fix transpose

* Fix

* Try to fix USE_TVM_OP not understood in .cu

* Fix squeeze

* Finally

* Fix

* Try to fix invalid ptx

* Implement API to get cuda compute capability

* Fix test_utils.py

* Fix pylint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@haojin2 haojin2 haojin2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reminisce @haojin2