Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@stu1130
Copy link
Contributor

@stu1130 stu1130 commented Oct 7, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

for axis in ([i for i in range(in_data_dim)] + [(), None]):
for itype in ['float16', 'float32', 'float64', 'int']:
# test gluon
print(func, hybridize, keepdims, axis, itype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print(shape) here?

@stu1130 stu1130 force-pushed the fix_numpy_max_min_flakiness branch from 9cbe549 to d9adb0c Compare October 7, 2019 23:24
@stu1130
Copy link
Contributor Author

stu1130 commented Oct 8, 2019

@stu1130 stu1130 force-pushed the fix_numpy_max_min_flakiness branch from d9adb0c to 8003d47 Compare October 8, 2019 04:18
@stu1130 stu1130 force-pushed the fix_numpy_max_min_flakiness branch from 8003d47 to 33a5290 Compare October 8, 2019 04:30
@junrushao
Copy link
Member

Hey, is this PR relevant to the recent fix?

@stu1130
Copy link
Contributor Author

stu1130 commented Oct 10, 2019

yes, I can close it

@stu1130 stu1130 closed this Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants