This repository was archived by the owner on Nov 17, 2023. It is now read-only.
make TransposeShape infer shape form both sides #15713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@dtracz Can you look into the CI failures ? |
ptrendx
reviewed
Jul 31, 2019
Member
|
@dtracz As discussed offline, please add a small unit test for this fix, then LGTM. |
ptrendx
approved these changes
Aug 1, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* make TransposeShape infer shape form both sides * small fixes * remove redundant lines * unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the function TransposeShape use both input and output data. Base on this it completes all unknown dimension sizes. If any of them is know on both sides the function checks if they match.