Skip to content

Add Test cases for the repair of BF algorithm of dependent package wh…#174

Closed
weibo1995 wants to merge 1 commit intoapache:masterfrom
weibo1995:bf-bugfix-ut
Closed

Add Test cases for the repair of BF algorithm of dependent package wh…#174
weibo1995 wants to merge 1 commit intoapache:masterfrom
weibo1995:bf-bugfix-ut

Conversation

@weibo1995
Copy link
Contributor

Add Test cases for the repair of BF algorithm of dependent package when children are empty( #172 ).

After adding, it covers two cases.

The first is that the dependent package of no children is on the left. The dependencies are as follows:
image
The expected final dependency tree after conflict resolving is as follows:
image

The second is that the dependent package of no children is on the right. The dependencies are as follows:
image

The expected final dependency tree after conflict resolving is as follows:
image

thanks.

Signed-off-by: hongbo.weihb hongbo.weihb@alibaba-inc.com

…en children are empty

Signed-off-by: hongbo.weihb <hongbo.weihb@alibaba-inc.com>
@cstamas
Copy link
Member

cstamas commented May 10, 2022

Superseded by #175

@cstamas cstamas closed this May 10, 2022
cstamas added a commit that referenced this pull request May 11, 2022
This PR is #174 but also collapses tests.

Majority of UTs are assuring that both implementation works "equally same". The implementation specific ones should go to each subclass. Also, skipper on/off was not fully covered, now is.

Signed-off-by: hongbo.weihb <hongbo.weihb@alibaba-inc.com>
Co-authored-by: hongbo.weihb <hongbo.weihb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants