Conversation
...solver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/ConflictWinnerFinder.java
Outdated
Show resolved
Hide resolved
...solver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/ConflictWinnerFinder.java
Outdated
Show resolved
Hide resolved
| ); | ||
| if ( useSkipReconcile ) | ||
| { | ||
| LOGGER.debug( "Collector skip & reconcile enabled." ); |
There was a problem hiding this comment.
I think such a message is redundant as well because the user explicitly wanted to skip this.
There was a problem hiding this comment.
It was present in original PR by @caiwei-ebay so let's wait for his response here
There was a problem hiding this comment.
Thanks for reviewing and updating the PR.
I provide a property just for compatibility consideration. As I'm confident with the "skip & reconcile" approach as we've dryrun 2000+ applications in our company, so I would raise both hands in favour of that we don't provide a property to disable this behavior.
...-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
Outdated
Show resolved
Hide resolved
...-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
Outdated
Show resolved
Hide resolved
...impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyResolveReconciler.java
Outdated
Show resolved
Hide resolved
...impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyResolveReconciler.java
Outdated
Show resolved
Hide resolved
|
The code changes looks good to me and it's much cleaner. Thanks for updating the PR. Thanks, |
|
@caiwei-ebay Please integrate this into your PR first, then we will continue. |
|
Integrated into upstream branch. |
|
Resolve #1407 |
1 similar comment
|
Resolve #1407 |
Proposed changes for #136
@caiwei-ebay please take a look
Changes: