Remove unused public methods in AllGroupHeadsCollector - #16385
Open
gaobinlong wants to merge 4 commits into
Open
Remove unused public methods in AllGroupHeadsCollector#16385gaobinlong wants to merge 4 commits into
gaobinlong wants to merge 4 commits into
Conversation
Contributor
Author
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
javanna
reviewed
Jul 28, 2026
javanna
left a comment
Contributor
There was a problem hiding this comment.
This is good but I think that we need to update the package-info too, and update that collector example. Thanks!
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Contributor
Author
Changed that, please help take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After we replace all of the usage of AllGroupHeadsCollector with AllGroupHeadsCollectorManager, now we can safely remove the unused public methods in AllGroupHeadsCollector, users can call equivalent methods in the collector manager instead.