[LIVY-1059] Fix missing validation condition and add unit test#531
Merged
Conversation
gyogal
approved these changes
Jul 8, 2026
gyogal
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for fixing this, @nileshrathi345 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up fix for LIVY-1059.
When a client sends
"queue": ""in the session create JSON, Livy was treating it as a valid queue value instead of falling back to the server defaultlivy.spark.yarn.queue.This change treats an empty queue string the same as a missing queue, so the default YARN queue from Livy config is used when the client passes "".
Updated in both batch and interactive session creation:
request.queue.filterNot(_.isEmpty).orElse(livyConf.sparkYarnQueue())How was this patch tested?
BatchSessionSpecforqueue = Some("")and verified the default queue is passed to spark-submitInteractiveSessionSpecforqueue = Some("")and verified the session uses the default queue fromLivyConfqueue = Noneand user-provided queue values still pass