Disable multi-node REMOVE statements - #18360
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18360 +/- ##
============================================
+ Coverage 43.14% 43.41% +0.27%
Complexity 374 374
============================================
Files 5364 5366 +2
Lines 382623 382956 +333
Branches 49749 49809 +60
============================================
+ Hits 165077 166259 +1182
+ Misses 217546 216697 -849 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR restricts cluster-node removal statements to a single node ID in both SQL dialects.
REMOVE DATANODEaccepts exactly one DataNode IDREMOVE DATANODE/REMOVE CONFIGNODEstatements and reject multiple node IDsTests
mvn -q test -pl iotdb-core/datanode -am -Dtest=RemoveNodeSingleNodeParseTest,RemoveNodeSingleNodeStatementTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false63a44a745aRunningwith matchingBuildInfo, with schema and data replication factors set to 2REMOVE DATANODEandREMOVE CONFIGNODEstatements at the comma