Skip to content

feat(connectors): add mongodb source connector#3285

Open
Luishfs wants to merge 10 commits into
apache:masterfrom
Luishfs:feature/mongodb_source
Open

feat(connectors): add mongodb source connector#3285
Luishfs wants to merge 10 commits into
apache:masterfrom
Luishfs:feature/mongodb_source

Conversation

@Luishfs

@Luishfs Luishfs commented May 20, 2026

Copy link
Copy Markdown

Which issue does this PR close?

Closes #3042

Rationale

What changed?

Added MongoDB as a source connector

Local Execution

  • Passed
    Video
simplescreenrecorder2-2026-05-20_08.15.01.mp4

showing results ( with the master branch updated, since last video was a month ago )

  • Pre-commit hooks passed
    last commit with prek
Screenshot from 2026-05-20 08-25-13

AI Usage

  1. Claude
  2. Claude for general rust questions & MongoDB insertion bash i used in the video
  3. Didn't use generated code
  4. Yes ( just might need a bit of time since i pushed it just now =P )

@github-actions

Copy link
Copy Markdown

Thanks for the pull request. It is now waiting for review, labeled S-waiting-on-review.

You can update that label as the review goes back and forth, with slash commands - each on its own line, in a regular PR comment (not an inline review reply):

  • /ready - mark it S-waiting-on-review again, after addressing feedback
  • /author - mark it S-waiting-on-author (maintainers, or anyone who has had a PR merged before)
  • /request-review @user ... - request reviewers (@user or @org/team)

Commands take up to ~90s to apply. If no reaction (👍 or 😕) appears on your comment, the apply step likely failed - check the repo's Actions tab for the PR Triage Apply run. Commands posted inside a review body (rather than a normal comment) cannot be reacted to, so they stay log-only.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label May 20, 2026
@hubcio

hubcio commented May 20, 2026

Copy link
Copy Markdown
Contributor

@amuldotexe maybe you wanna take a stab at reviewing this? :) from quick glance I can see that docs are not updated and no actual integration tests are added.

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.79%. Comparing base (bf77e99) to head (e65a7ba).

Files with missing lines Patch % Lines
core/connectors/sources/mongodb_source/src/lib.rs 86.66% 4 Missing and 10 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3285       +/-   ##
=============================================
- Coverage     74.57%   46.79%   -27.79%     
  Complexity      937      937               
=============================================
  Files          1249     1247        -2     
  Lines        123564   108060    -15504     
  Branches      99839    84363    -15476     
=============================================
- Hits          92150    50564    -41586     
- Misses        28430    54805    +26375     
+ Partials       2984     2691      -293     
Components Coverage Δ
Rust Core 39.95% <86.66%> (-35.78%) ⬇️
Java SDK 58.57% <ø> (ø)
C# SDK 69.44% <ø> (-0.48%) ⬇️
Python SDK 81.06% <ø> (ø)
PHP SDK 83.57% <ø> (ø)
Node SDK 91.26% <ø> (+0.03%) ⬆️
Go SDK 40.25% <ø> (ø)
Files with missing lines Coverage Δ
core/connectors/sources/mongodb_source/src/lib.rs 86.66% <86.66%> (ø)

... and 365 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hubcio

hubcio commented May 20, 2026

Copy link
Copy Markdown
Contributor

for now @Luishfs please fix CI (commit Cargo.lock) and add integration tests.
/author

@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels May 20, 2026
@Luishfs

Luishfs commented May 27, 2026

Copy link
Copy Markdown
Author

@hubcio Hey, sorry for the wait, had a couple of things going on but just addressed your comments.
I'm going to be more active from now on since i have a couple of ideas i want to implement as sources/sinks, but will wait until i've done everything on the mongodb source

@hubcio

hubcio commented May 27, 2026

Copy link
Copy Markdown
Contributor

@Luishfs no worries, take your time. you can also chime-in on discord, there's connectors channel so we can discuss those ideas. feel free to ping me. 🦀

@Luishfs Luishfs changed the title Feature/mongodb source feat: add mongodb source connector May 28, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.

Thank you for your contribution!

@github-actions github-actions Bot added the S-stale Inactive issue or pull request label Jun 5, 2026
@slbotbm

slbotbm commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@Luishfs Is this PR ready for review?

@github-actions github-actions Bot removed the S-stale Inactive issue or pull request label Jun 11, 2026
@Luishfs Luishfs changed the title feat: add mongodb source connector feat(connectors): add mongodb source connector Jun 11, 2026
@Luishfs

Luishfs commented Jun 11, 2026

Copy link
Copy Markdown
Author

@hubcio i believe i've covered the last workflow issues, along with running all the checks listed under contributing, can we proceed on review?

@Luishfs

Luishfs commented Jun 11, 2026

Copy link
Copy Markdown
Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Jun 11, 2026

@hubcio hubcio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Cargo.toml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain the reasoning behind all changes in this file. why did you remove these deps in mongodb connector PR?

@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author PR is waiting on author response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MongoDB Source Connector

3 participants