Spark: remove ROW_POSITION from project schema#11610
Merged
flyrain merged 2 commits intoapache:mainfrom Nov 28, 2024
Merged
Conversation
Contributor
Author
flyrain
approved these changes
Nov 21, 2024
Contributor
flyrain
left a comment
There was a problem hiding this comment.
+1, do we need it in older spark version?
Contributor
Author
|
@flyrain Yes, we need the same change in the older version too. Just added the changes. |
Contributor
|
Thanks for the change, @huaxingao ! |
Contributor
Author
|
Thanks @flyrain |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, we have
ReadConfig#generateOffsetToStartPos(Schema schema)to compute the row offsets of the row groups. This method needs to check if the schema contains ROW_POSITION. #11520 uses native getRowIndexOffset so we don't needgenerateOffsetToStartPosany more. As a result, we don't need to add ROW_POSITION to the schema any more.