Skip to content

Expose Catalog trait as python binding#604

Closed
kevinjqliu wants to merge 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/expose-catalog
Closed

Expose Catalog trait as python binding#604
kevinjqliu wants to merge 1 commit intoapache:mainfrom
kevinjqliu:kevinjqliu/expose-catalog

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Sep 5, 2024

#538

hatch run dev:develop

@kevinjqliu
Copy link
Contributor Author

First time writing rust, most of this code is generated but helped me understand the codebase.
Here are a couple of things I've learned

Hi, @kevinjqliu I'm fine with adding it in pyiceberg_core module. But instead of adding sql catalog only, I think it's better to add a wrapper around Catalog trait? What do you think?

@liurenjie1024, following up on this comment #534 (comment)
Is the idea to expose only the Catalog trait to python? And perhaps a function to create different catalog implementations similar to what load_catalog is doing in python?

@liurenjie1024
Copy link
Contributor

Is the idea to expose only the Catalog trait to python? And perhaps a function to create different catalog implementations similar to what load_catalog is doing in python?

@kevinjqliu Sorry for late reply. Yeah, this looks good to me.

@kevinjqliu kevinjqliu mentioned this pull request Apr 7, 2025
28 tasks
@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants