Fix/skip serialize null fields unit tests#2155
Open
mattefunnel wants to merge 2 commits intoapache:mainfrom
Open
Fix/skip serialize null fields unit tests#2155mattefunnel wants to merge 2 commits intoapache:mainfrom
mattefunnel wants to merge 2 commits intoapache:mainfrom
Conversation
1105050 to
d490ec3
Compare
Add round-trip serialization tests that verify optional fields are omitted (not serialized as null) when absent, as requested in apache#2136. - CreateTableRequest: full and minimal round-trip serde test - UnboundPartitionSpec: assert serialized output matches expected JSON
d490ec3 to
335fbd8
Compare
Contributor
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2135
What changes are included in this PR?
Unit tests for #2136
(But it is based on
jonbjo:fix/skip-serialize-null-fieldsfrom that PR, so it also has those changes.)Are these changes tested?
Yes. The original PR contained the changes, this PR contains those changes and additional unit tests.
Note about failing Bindings Python CI test: