Skip to content

[Bug Fix] Update "partition-spec" and "schema" for V1 table in update_table_metadata#547

Closed
HonahX wants to merge 1 commit intoapache:mainfrom
HonahX:bug_fix/v1_table_update
Closed

[Bug Fix] Update "partition-spec" and "schema" for V1 table in update_table_metadata#547
HonahX wants to merge 1 commit intoapache:mainfrom
HonahX:bug_fix/v1_table_update

Conversation

@HonahX
Copy link
Contributor

@HonahX HonahX commented Mar 25, 2024

"partition-spec" and "schema" are deprecated but required field in v1 table metadata. For backward compatibility, I think we should to update "partition-spec" when applying SetDefaultSpecUpdate and "schema" when applying SetCurrentSchemaUpdate.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is more correct, however they are officially deprecated (for quite a while). WDYT @rdblue @danielcweeks?

Let's wait for what their thoughts are. Another route would be to do this in Pydantic when serializing to JSON.

@github-actions
Copy link

github-actions bot commented Mar 7, 2026

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 7, 2026
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants