-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[feature]Make GreptimeDB as a grafana data source #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ource support for GreptimeDB - Update dashboard creation to remove 'id' field and handle errors more gracefully - Enhance dashboard deletion to check for success and handle not found errors - Add support for creating datasources with additional configuration for GreptimeDB - Refactor datasource creation to use a new DatasourceRequest class - Update GreptimeDB table naming convention and add database parameter to queries
- Remove unused code and comments - Consolidate Prometheus collection logic- Add TODO for future refactoring consideration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 3235 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1649 | 1 | 1585 | 0 |
Click to see the invalid file list
- hertzbeat-collector/hertzbeat-collector-basic/src/main/java/org/apache/hertzbeat/collector/collect/prometheus/PrometheusCollect.java
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
...basic/src/main/java/org/apache/hertzbeat/collector/collect/prometheus/PrometheusCollect.java
Show resolved
Hide resolved
…g/apache/hertzbeat/collector/collect/prometheus/PrometheusCollect.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Logic <[email protected]>
- Remove unused code and comments - Consolidate Prometheus collection logic- Add TODO for future refactoring consideration
- Enhance code readability in DashboardService by formatting and simplifying URL construction - Add class-level documentation for DatasourceService and DatasourceRequest - Update method-level documentation in DatasourceService
- Add class-level documentation for PrometheusProxyConfig - Remove unused import statements
|
👍hi, what the different between PrometheusProxyCollectImpl and PrometheusAutoCollectImpl, can you share the design of this piece?? |
Currently, the proxy code is marked as todo because for the current architecture, although proxy can reduce the load on hertzbeat, direct forwarding to the database makes alerting impossible. I'm sure he'll be useful as a future feature for lossless collection of metrics! |
tomsun28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make greptime available as a grafana data source.

Checklist
Add or update API