Skip to content

Conversation

@pwallk
Copy link
Contributor

@pwallk pwallk commented May 10, 2025

What's changed?

#3321

eureka

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Calvin979
Calvin979 previously approved these changes May 10, 2025
Copy link
Contributor

@Calvin979 Calvin979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 added this to the 1.7.1 milestone May 12, 2025
@tomsun28 tomsun28 linked an issue May 12, 2025 that may be closed by this pull request
9 tasks
Copy link
Member

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuluo-yx yuluo-yx merged commit 3eba906 into apache:master May 12, 2025
4 checks passed
@pwallk pwallk deleted the feat-eureka-sd branch May 21, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] <Support more monitoring service auto discovery way>

4 participants