Skip to content

Conversation

@MasamiYui
Copy link
Member

@MasamiYui MasamiYui commented Apr 21, 2025

What's changed?

#3279
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 22, 2025
@tomsun28 tomsun28 added this to the 1.7.1 milestone Apr 22, 2025
@tomsun28 tomsun28 linked an issue Apr 22, 2025 that may be closed by this pull request
2 tasks
@tomsun28 tomsun28 self-requested a review April 22, 2025 01:18
@tomsun28
Copy link
Member

hi there has some unit test failed.

[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 s - in org.apache.hertzbeat.manager.service.ObjectStoreConfigServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.AppServiceTest
Error:  Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.229 s <<< FAILURE! - in org.apache.hertzbeat.manager.service.AppServiceTest
Error:  getI18nResources  Time elapsed: 0.22 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "org.apache.hertzbeat.manager.dao.DefineDao.findAll()" because "this.this$0.defineDao" is null
	at org.apache.hertzbeat.manager.service.AppServiceTest.setUp(AppServiceTest.java:58)

Error:  getAllAppHierarchy  Time elapsed: 0.001 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "org.apache.hertzbeat.manager.dao.DefineDao.findAll()" because "this.this$0.defineDao" is null
	at org.apache.hertzbeat.manager.service.AppServiceTest.setUp(AppServiceTest.java:58)

Error:  getAppDefineMetricNames  Time elapsed: 0.002 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "org.apache.hertzbeat.manager.dao.DefineDao.findAll()" because "this.this$0.defineDao" is null
	at org.apache.hertzbeat.manager.service.AppServiceTest.setUp(AppServiceTest.java:58)

Error:  getAppParamDefines  Time elapsed: 0.002 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "org.apache.hertzbeat.manager.dao.DefineDao.findAll()" because "this.this$0.defineDao" is null
	at org.apache.hertzbeat.manager.service.AppServiceTest.setUp(AppServiceTest.java:58)

Error:  getAppDefine  Time elapsed: 0.001 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "org.apache.hertzbeat.manager.dao.DefineDao.findAll()" because "this.this$0.defineDao" is null
	at org.apache.hertzbeat.manager.service.AppServiceTest.setUp(AppServiceTest.java:58)

[INFO] Running org.apache.hertzbeat.manager.service.AiServiceFactoryTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.098 s - in org.apache.hertzbeat.manager.service.AiServiceFactoryTest
[INFO] Running org.apache.hertzbeat.manager.service.MailGeneralConfigServiceTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s - in org.apache.hertzbeat.manager.service.MailGeneralConfigServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.ObsObjectStoreServiceTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.666 s - in org.apache.hertzbeat.manager.service.ObsObjectStoreServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.TemplateConfigServiceTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.066 s - in org.apache.hertzbeat.manager.service.TemplateConfigServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.MonitorServiceTest
[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.483 s - in org.apache.hertzbeat.manager.service.MonitorServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.SystemSecretServiceTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s - in org.apache.hertzbeat.manager.service.SystemSecretServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.ExcelImExportServiceTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.51 s - in org.apache.hertzbeat.manager.service.ExcelImExportServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.ConfigServiceTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 s - in org.apache.hertzbeat.manager.service.ConfigServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.YamlImExportServiceTest
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 s - in org.apache.hertzbeat.manager.service.YamlImExportServiceTest
[INFO] Running org.apache.hertzbeat.manager.service.BulletinServiceTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.082 s - in org.apache.hertzbeat.manager.service.BulletinServiceTest
[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    AppServiceTest.setUp:58 » NullPointer Cannot invoke "org.apache.hertzbeat.mana...
Error:    AppServiceTest.setUp:58 » NullPointer Cannot invoke "org.apache.hertzbeat.mana...
Error:    AppServiceTest.setUp:58 » NullPointer Cannot invoke "org.apache.hertzbeat.mana...
Error:    AppServiceTest.setUp:58 » NullPointer Cannot invoke "org.apache.hertzbeat.mana...
Error:    AppServiceTest.setUp:58 » NullPointer Cannot invoke "org.apache.hertzbeat.mana...
[INFO] 
Error:  Tests run: 192, Failures: 0, Errors: 5, Skipped: 0

Copy link
Member

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28 tomsun28 merged commit 227666d into apache:master Apr 22, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from To do to Done in Apache HertzBeat Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Task] <Use the local database to store monitoring yml update file by default>

3 participants