Skip to content

Conversation

@tomsun28
Copy link
Member

What's changed?

  • update api auth method

for some maybe use xxx@xxx as password, it will work failed when pre auth method.

  • add expose url param

for some env the inner access grafana server url and extern access url may not same.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 requested a review from zqr10159 November 17, 2024 02:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.56%. Comparing base (be84a0a) to head (45b2046).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
.../history/vm/VictoriaMetricsClusterDataStorage.java 0.00% 3 Missing ⚠️
...e/store/history/vm/VictoriaMetricsDataStorage.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2818      +/-   ##
============================================
- Coverage     32.57%   32.56%   -0.01%     
  Complexity     1904     1904              
============================================
  Files           496      496              
  Lines         18310    18314       +4     
  Branches       2249     2251       +2     
============================================
  Hits           5964     5964              
- Misses        11649    11653       +4     
  Partials        697      697              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zqr10159 zqr10159 merged commit eaaf589 into master Nov 18, 2024
3 checks passed
@zqr10159 zqr10159 deleted the update-grafana branch November 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants