Skip to content

Conversation

@Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Jun 8, 2024

What's changed?

Relate issue: #1549
image

Seems it is difficult to get public ip in Java directly, therefore I add a configuration public-ip-env for getting public ip from environment.
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28
Copy link
Member

tomsun28 commented Jun 8, 2024

hi thanks lgtm !👍👍 Suggest we can combine the ip and public ip into one ip.
When user custom config the collector ip like below, we use the custom ip, else we use the ip we detect by program like before.

collector:
  info: 
     version: 1.5.0
     ip: 38.44.3.5

@Calvin979
Copy link
Contributor Author

hi thanks lgtm !👍👍 Suggest we can combine the ip and public ip into one ip. When user custom config the collector ip like below, we use the custom ip, else we use the ip we detect by program like before.

collector:
  info: 
     version: 1.5.0
     ip: 38.44.3.5

Code has been updated by your suggestion.

@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 9, 2024
Copy link
Member

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Question] [Collection Cluster] page, whether it is possible to add two columns of "Collector Version" and "Collector IP Address"

2 participants