Skip to content

Conversation

@TJxiaobao
Copy link
Contributor

@TJxiaobao TJxiaobao commented Apr 11, 2024

What's changed?

influxdb monitoring indicators are added.
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@TJxiaobao TJxiaobao requested a review from tomsun28 April 11, 2024 05:45
tomsun28
tomsun28 previously approved these changes Apr 11, 2024
Copy link
Member

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28
Copy link
Member

link #1717

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 11, 2024
@tomsun28
Copy link
Member

👍 btw we can modify here https://github.com/dromara/hertzbeat/blob/master/home/sidebars.json#L129 to add influxdb menu in home website

@TJxiaobao
Copy link
Contributor Author

Okay, I'll give it a try.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Apr 27, 2024
# Conflicts:
#	home/sidebars.json
@tomsun28 tomsun28 changed the title add:influxdb monitoring indicators are added [feature] add influxdb metrics monitoring Apr 27, 2024
@tomsun28 tomsun28 merged commit d3209b6 into master Apr 27, 2024
@TJxiaobao TJxiaobao deleted the influxdb_monitors_v1 branch July 17, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend doc Improvements or additions to documentation docs enhancement New feature or request good first pull request Good for newcomers monitoring-template

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants