Skip to content

HBASE-26687 Avoid the newBuilder(RegionInfo) constructor in RegionInf… #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshelser merged 2 commits into from
Jan 20, 2022
Merged

HBASE-26687 Avoid the newBuilder(RegionInfo) constructor in RegionInf… #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
040dacd
HBASE-26687 Avoid the newBuilder(RegionInfo) constructor in RegionInf…
joshelser Jan 19, 2022
d03fc33
Fix checkstyle and remove an unnecessary comment
joshelser Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion hbase-hbck2/src/main/java/org/apache/hbase/RegionInfoMismatchTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,17 @@ void run(PrintStream out, boolean fix) throws IOException, DeserializationExcept
}
// Third component of a region name is just a literal numeric (not a binary-encoded long)
long regionId = Long.parseLong(Bytes.toString(regionNameParts[2]));
RegionInfo correctedRegionInfo = RegionInfoBuilder.newBuilder(wrongRegionInfo)
// HBASE-24500: We cannot use newBuilder(RegionInfo) because it will copy the NAME and
// encodedName from the original RegionInfo instead of re-computing it. Copy all of the
// fields by hand which will force the new RegionInfo to recompute the NAME/encodedName
// fields.
RegionInfo correctedRegionInfo = RegionInfoBuilder.newBuilder(wrongRegionInfo.getTable())
.setRegionId(regionId)
.setStartKey(wrongRegionInfo.getStartKey())
.setEndKey(wrongRegionInfo.getEndKey())
.setReplicaId(0)
.setOffline(wrongRegionInfo.isOffline())
.setSplit(wrongRegionInfo.isSplit())
.build();

String rowkeyEncodedRegionName = HBCKRegionInfo.encodeRegionName(regionName);
Expand Down