[#8109] improvement(core): correct PostgreSQL ON CONFLICT syntax using EXCLUDED instead of VALUES#8125
Merged
justinmclean merged 1 commit intoapache:mainfrom Aug 17, 2025
Merged
Conversation
… in PostgreSQL ON CONFLICT query (apache#8109)
justinmclean
approved these changes
Aug 17, 2025
Member
justinmclean
left a comment
There was a problem hiding this comment.
Thanks, that looks good to me.
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Sep 15, 2025
…x using EXCLUDED instead of VALUES (apache#8125) ### What changes were proposed in this pull request? This PR fixes the incorrect SQL syntax in `UserRoleRelPostgreSQLProvider.java` by replacing `VALUES()` function calls with `EXCLUDED` references in the `ON CONFLICT ... DO UPDATE` clause. The change ensures proper PostgreSQL compatibility for upsert operations.\ ### Why are the changes needed? The current implementation uses MySQL-specific `VALUES()` function syntax in PostgreSQL provider, which is incorrect according to PostgreSQL documentation. PostgreSQL's `INSERT ... ON CONFLICT ... DO UPDATE` requires using `EXCLUDED` table alias to reference the values that would have been inserted, not the `VALUES()` function. Fix: apache#8109 ### Does this PR introduce _any_ user-facing change? No user-facing changes. This is a bug fix that ensures the existing functionality works correctly on PostgreSQL databases. ### How was this patch tested? Tested with existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the incorrect SQL syntax in
UserRoleRelPostgreSQLProvider.javaby replacingVALUES()function calls withEXCLUDEDreferences in theON CONFLICT ... DO UPDATEclause. The change ensures proper PostgreSQL compatibility for upsert operations.\Why are the changes needed?
The current implementation uses MySQL-specific
VALUES()function syntax in PostgreSQL provider, which is incorrect according to PostgreSQL documentation. PostgreSQL'sINSERT ... ON CONFLICT ... DO UPDATErequires usingEXCLUDEDtable alias to reference the values that would have been inserted, not theVALUES()function.Fix: #8109
Does this PR introduce any user-facing change?
No user-facing changes. This is a bug fix that ensures the existing functionality works correctly on PostgreSQL databases.
How was this patch tested?
Tested with existing tests.