ci: audit and update GitHub Actions to ASF-approved versions#512
Merged
Conversation
Pin every external GitHub Action to a full commit SHA from the ASF approved actions allow-list, with a trailing comment naming the version it resolves to. Mirrors the grails-core audit in apache/grails-core#15690. - actions/checkout -> de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 (was v4, v6) - actions/setup-java -> be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0 (was v4, v5) - gradle/actions/setup-gradle -> 50e97c2cd7a37755bbfafc9c5b7cafaece252f6e # v6.1.0 (was 017a9effdb900e5b5b2fddfb590a105619dca3c3 # v4.4.2, 0723195856401067f7a2779048b490ace7a47d7c # v5.0.2) - scacap/action-surefire-report -> 3dacff26879cd2a7f2160d101254032a3707fe6f # v1.12.0 (was 5609ce4db72c09db044803b344a8968fd1f315da # v1.9.1) - actions/cache -> 27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 (was v5) Add cache-provider: basic to all 3 setup-gradle steps so caching stays on the MIT-licensed provider rather than the proprietary enhanced provider introduced in gradle/actions v6 (Gradle commercial Terms of Use). First-party apache/grails-github-actions/* and local ./.github/actions/* references are intentionally left unchanged. Assisted-by: claude-code:claude-4.8-opus
There was a problem hiding this comment.
Pull request overview
This PR updates active GitHub Actions workflows to use ASF-approved, SHA-pinned external actions, with inline version comments. It also standardizes Gradle setup on gradle/actions/setup-gradle v6.1.0 using the MIT-licensed basic cache provider.
Changes:
- Pins third-party workflow actions to full commit SHAs with version comments.
- Updates checkout, setup-java, setup-gradle, cache, and surefire-report actions to newer approved versions.
- Adds
cache-provider: basicto allsetup-gradlesteps.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/rendersite.yml |
Pins checkout/setup-java/setup-gradle and configures Gradle basic cache provider. |
.github/workflows/release.yml |
Pins checkout and setup-java for the release workflow. |
.github/workflows/release-companion.yml |
Pins checkout and setup-java for companion release updates. |
.github/workflows/publish.yml |
Pins publish workflow actions and configures Gradle basic cache provider. |
.github/workflows/gradle.yml |
Pins CI workflow actions, updates surefire report action, and configures Gradle basic cache provider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Audit of every GitHub Action used in this repository against the ASF approved actions allow-list, updating each to its current approved version and pinning every external action to a full commit SHA with a trailing comment naming the version it resolves to.
This mirrors the audit performed on grails-core in apache/grails-core#15690 and brings this repository back onto supported, allow-list-approved action versions.
Why (setup-gradle)
The primary driver is
gradle/actions/setup-gradle:gradle/actionsv6.0.0moved caching into a proprietaryenhancedprovider governed by Gradle's commercial Terms of Use.v6.1.0reintroduced an MIT-licensedbasiccache provider.Standardizing on the approved
v6.1.0SHA withcache-provider: basic(3 steps) keeps us on a supported version while caching stays MIT-licensed. Eachcache-providerline carries an inline comment documenting the distinction.Changes
actions/checkoutde0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2actions/setup-javabe666c2fcd27ec809703dec50e508c2fdc7f6654 # v5.2.0gradle/actions/setup-gradle50e97c2cd7a37755bbfafc9c5b7cafaece252f6e # v6.1.0scacap/action-surefire-report3dacff26879cd2a7f2160d101254032a3707fe6f # v1.12.0actions/cache27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5Plus
cache-provider: basicadded to all 3setup-gradlesteps.First-party
apache/grails-github-actions/*references and local./.github/actions/*composites are intentionally left unchanged.Verification
# versioncomment; the only non-SHA refs remaining are the first-partyapache/*@asfones and local composite actions.