Reference Testcontainers BOM version from gradle.properties in guide prose#511
Merged
jamesfredley merged 1 commit intoMay 29, 2026
Merged
Conversation
…ide prose The grails-rest-library and grails-vite-spa testing chapters showed the testcontainers-bom version inline. The sample apps now keep that version in gradle.properties (as testcontainersVersion), so the chapters reference \ and show the gradle.properties entry, keeping the version in one place. Assisted-by: claude-code:claude-opus-4-7
There was a problem hiding this comment.
Pull request overview
This documentation-only PR updates two Grails 8 guide testing chapters to show the Testcontainers BOM version being referenced from gradle.properties via testcontainersVersion, matching the sample app configuration described in the PR.
Changes:
- Replaces inline
testcontainers-bom:1.20.4usage with$testcontainersVersion. - Adds
gradle.propertiessnippets showingtestcontainersVersion=1.20.4. - Uses the correct backend path for the multi-module Vite SPA guide.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
guides/grails-rest-library/v8/guide/testing.adoc |
Updates Testcontainers BOM dependency prose and adds the root gradle.properties version snippet. |
guides/grails-vite-spa/v8/guide/testing.adoc |
Updates backend Testcontainers BOM dependency prose and adds the backend/gradle.properties version snippet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #510. The sample apps now keep the Testcontainers BOM version in
gradle.properties(astestcontainersVersion) instead of hardcoding it inbuild.gradle, matching howgrailsVersionis managed and keeping the version in one place.This updates the two guide testing chapters that showed the version inline:
grails-rest-librarytesting chapter ->platform("org.testcontainers:testcontainers-bom:\")+ agradle.propertiessnippetgrails-vite-spatesting chapter -> same, referencingbackend/gradle.propertiesThe matching
grails-guides/*sample apps (grails-spock-test-tour,grails-rest-library,grails-github-actions-cicd,grails-vite-spa,grails-docker-bootbuildimage) were updated on theirgrails8branches.validateGuides: 93 guides, 0 errors. Both guides re-rendered cleanly.Assisted-by: claude-code:claude-opus-4-7