Skip to content

Controller Test scaffolding template improved: 1) Valid properties are no #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graemerocher merged 1 commit into from
Aug 30, 2011
Merged

Controller Test scaffolding template improved: 1) Valid properties are no #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions grails-resources/src/grails/templates/scaffolding/Test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ import javax.servlet.http.HttpServletResponse
@Mock(${className})
class ${className}ControllerTests {


def populateValidParams(params) {
assert params != null
// TODO: Populate valid properties like...
//params["name"] = 'someValidName'
}

void testIndex() {
controller.index()
assert "/$propertyName/list" == response.redirectedUrl
Expand Down Expand Up @@ -40,8 +47,7 @@ class ${className}ControllerTests {

response.reset()

// TODO: Populate valid properties

populateValidParams(params)
controller.save()

assert response.redirectedUrl == '/${propertyName}/show/1'
Expand All @@ -56,9 +62,8 @@ class ${className}ControllerTests {
assert response.redirectedUrl == '/${propertyName}/list'


def ${propertyName} = new ${className}()

// TODO: populate domain properties
populateValidParams(params)
def ${propertyName} = new ${className}(params)

assert ${propertyName}.save() != null

Expand All @@ -76,9 +81,8 @@ class ${className}ControllerTests {
assert response.redirectedUrl == '/${propertyName}/list'


def ${propertyName} = new ${className}()

// TODO: populate valid domain properties
populateValidParams(params)
def ${propertyName} = new ${className}(params)

assert ${propertyName}.save() != null

Expand All @@ -104,14 +108,14 @@ class ${className}ControllerTests {
response.reset()


def ${propertyName} = new ${className}()

// TODO: populate valid domain properties
populateValidParams(params)
def ${propertyName} = new ${className}(params)

assert ${propertyName}.save() != null

// test invalid parameters in update
params.id = ${propertyName}.id
//TODO: add invalid values to params object

controller.update()

Expand All @@ -120,11 +124,25 @@ class ${className}ControllerTests {

${propertyName}.clearErrors()

// TODO: populate valid domain form parameter
populateValidParams(params)
controller.update()

assert response.redirectedUrl == "/${propertyName}/show/\$${propertyName}.id"
assert flash.message != null

//test outdated version number
response.reset()
${propertyName}.clearErrors()

populateValidParams(params)
params.id = ${propertyName}.id
params.version = -1
controller.update()

assert view == "/${propertyName}/edit"
assert model.${propertyName}Instance != null
assert model.${propertyName}Instance.errors.getFieldError('version')
assert flash.message != null
}

void testDelete() {
Expand All @@ -139,9 +157,9 @@ class ${className}ControllerTests {

response.reset()

def ${propertyName} = new ${className}()
populateValidParams(params)
def ${propertyName} = new ${className}(params)

// TODO: populate valid domain properties
assert ${propertyName}.save() != null
assert ${className}.count() == 1

Expand Down