Skip to content

FINERACT-897 - Added missing grouping keywords from https://github.com/apache/fi…#780

Merged
vorburger merged 1 commit intoapache:developfrom
nemux:develop
Apr 22, 2020
Merged

FINERACT-897 - Added missing grouping keywords from https://github.com/apache/fi…#780
vorburger merged 1 commit intoapache:developfrom
nemux:develop

Conversation

@nemux
Copy link
Contributor

@nemux nemux commented Apr 22, 2020

Some keywords escaped from grouping are missing at #757.

@vorburger vorburger merged commit 78ca45e into apache:develop Apr 22, 2020
@vorburger
Copy link
Member

Thanks! So this is strictly required for MySQL v8? These things have a tendency to creep back in, over time... ;-) Any thoughts about how to prevent that? Would you like to try switching the Travis CI configuration to use MySQL v8?

@nemux
Copy link
Contributor Author

nemux commented Apr 22, 2020

Thanks! So this is strictly required for MySQL v8? These things have a tendency to creep back in, over time... ;-) Any thoughts about how to prevent that? Would you like to try switching the Travis CI configuration to use MySQL v8?

Yes @vorburger , according to the MySQL reference manual GROUPING became a reserved word in 8.0.1 https://dev.mysql.com/doc/refman/8.0/en/keywords.html

imagen

Let me make a test in a previous MySQL version using GROUPING quoted, but according to the documentation should be allowed quoted or not because in previous versions is not a reserved word.

imagen

@nemux
Copy link
Contributor Author

nemux commented Apr 22, 2020

And I think we are going to have problems in Travis CI with that switch because the current version of Drizzle. The code itself do not support the new version because little changes:
imagen
The @@tx_isolation was renamed in 8.0+ to @@transaction_isolation and this need to be changed in Drizzle to work krummas/DrizzleJDBC@ccd8a2c unfortunately as you saw, the project looks dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants