Skip to content

add link to Web UIs, Mobile App, and fineract.dev#779

Merged
vorburger merged 1 commit intodevelopfrom
vorburger-README-fineract.dev
Apr 26, 2020
Merged

add link to Web UIs, Mobile App, and fineract.dev#779
vorburger merged 1 commit intodevelopfrom
vorburger-README-fineract.dev

Conversation

@vorburger
Copy link
Member

No description provided.

@vorburger
Copy link
Member Author

#783 ignores the failing test. I'm closing and re-opening to see if it passes.

@awasum do you want to review and Rebase and Merge this REVIEW change?

@vorburger vorburger closed this Apr 26, 2020
@vorburger vorburger reopened this Apr 26, 2020
@awasum
Copy link
Contributor

awasum commented Apr 26, 2020

Seems there is a problem.

org.apache.fineract.integrationtests.RecurringDepositTest > testRecurringDepositAccountWithPrematureClosureTypeReinvest FAILED
    java.lang.AssertionError at RecurringDepositTest.java:3048

@awasum
Copy link
Contributor

awasum commented Apr 26, 2020

@vorburger
Copy link
Member Author

#784

@vorburger vorburger force-pushed the vorburger-README-fineract.dev branch from 5d2edc3 to d49e6ea Compare April 26, 2020 14:57
@vorburger
Copy link
Member Author

@nikpawar89 @xurror thanks for your interest and votes of support for the README change in #782.

How do you feel about this one?

@nikpawar89
Copy link
Member

@vorburger just thinking out loud- do we want to mention https://github.com/openMF/mifosx for pentaho reports related module? otherwise +1 from me.

Copy link
Contributor

@xurror xurror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awasum
Copy link
Contributor

awasum commented Apr 26, 2020

@vorburger just thinking out loud- do we want to mention https://github.com/openMF/mifosx for pentaho reports related module? otherwise +1 from me.

Hmm..Good one...But pentaho reports with current Fineract is even broken.

@vorburger
Copy link
Member Author

@vorburger just thinking out loud- do we want to mention https://github.com/openMF/mifosx for pentaho reports related module?

No, I'm actively against that, because I fear that could create a lot more confusion than answer anyone's question... that repo de facto is "dead", given that it hasn't been updated in 4 years, and IMHO we shouldn't refer to it anymore from Fineract's README (other than perhaps from a "Historical" section for archaeologists, if anyone would like to add something like that).

I do understand the (old) issue about Pentaho-based reports having been "lost" in the move to Apache. That is a problem I suspect someone will want to address somehow, someday (with a separate additional service, perhaps?), but this PR is not the place for that?

Anyway, strictly speaking, https://github.com/openMF/mifosx is course not the "pentaho reports related module", but a (now very old) predecessor version of the same code that is in this repo. (You cannot "use" that "module" with fineract, just like that.)

otherwise +1 from me.

Ok, then based on that +1 and @xurror approval, let's merge this, if OK for you as-is @awasum ?

PS: Build failed again due to another FINERACT-885 - I'll deal with that separately, let's not hold this up.

@awasum
Copy link
Contributor

awasum commented Apr 26, 2020

Go ahead. @vorburger

@vorburger vorburger merged commit d3aebf5 into develop Apr 26, 2020
@vorburger vorburger deleted the vorburger-README-fineract.dev branch May 9, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants