add MySQL JDBC Driver (LGPL) to Dockerfile + doc (fixes FINERACT-762)#760
Merged
vorburger merged 2 commits intoapache:developfrom Apr 17, 2020
Merged
Conversation
adb61a4 to
d05cd90
Compare
Member
Author
|
This failed to build again, due to flaky test which #761 will comment out... |
Note that it is NOT enabled by default, which should be OK for the ASF. The main point here is just to clearly document it for end-users. I've obviously tried out what's documented, and can confirm it works.
d05cd90 to
410a562
Compare
Member
Author
|
@awasum review and merge this one? Thanks! |
awasum
approved these changes
Apr 17, 2020
Contributor
awasum
left a comment
There was a problem hiding this comment.
LGTM. Merging soon as post merge Travis task is completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that it is NOT enabled by default, which should be OK for the ASF.
The main point here is just to clearly document it for end-users.
I've obviously tried out what's documented, and can confirm it works.