clean-up to remove apparently unused PORT ENV (related to FINERACT-762)#756
Merged
vorburger merged 1 commit intoapache:developfrom Apr 17, 2020
Merged
Conversation
903366c to
d70fd3c
Compare
Member
Author
|
In addition to https://issues.apache.org/jira/browse/FINERACT-762, see also future https://issues.apache.org/jira/browse/FINERACT-889 for more background about this. |
Member
Author
|
PR failed due to SchedulerJobsTest > testSchedulerJob (see https://jira.apache.org/jira/browse/FINERACT-852) ... let's close and re-open tomorrow to see if a new build goes through. |
Member
Author
|
This failed due to what #764 will fix (work around, deactivating test..); let's rebase this once that is in. |
Contributor
|
#764 has been merged. lets run this or rebase with develop and see. |
This environment variable is actually never used. The port of a Tenant DB instead appears to be read from schemaServerPort of the tenant_server_connections table.
d70fd3c to
b30918b
Compare
Member
Author
|
@awasum this PR just passed the build, and I'll self merge it, assuming you'll have no objections. (FTR: There are still flaky test problems, this one seems to have passed more by chance, others failed; I'll follow-up.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.