[ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties by Pil0tXia · Pull Request #4839 · apache/eventmesh

Pil0tXia · 2024-04-14T13:50:01Z

Modifications

Deprecate eventMesh.connector.plugin.type: EventMesh does not use this config to determine which connector to use. This config can easily confuse users. It is not referenced in implementation code either.

Deprecate registerIntervalInMills, fetchRegistryAddrIntervalInMills: These two configs were placed seperatly from metaStorage plugins, however they are always (in Git history) misconfigured (missing plugin level) & not used since EventMesh initiated.

eventmesh/eventmesh-runtime/conf/eventmesh.properties

Lines 63 to 64 in fe2bd7c

    
           eventMesh.server.metaStorage.metaStorageIntervalInMills=10000 
        
           eventMesh.server.metaStorage.fetchMetaStorageAddrIntervalInMills=20000

eventmesh/eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java

Lines 70 to 74 in fe2bd7c

    
           @ConfigField(field = "metaStorage.plugin.metaStorageIntervalInMills") 
        
           private Integer eventMeshMetaStorageIntervalInMills = 10 * 1000; 
        
           @ConfigField(field = "metaStorage.plugin.fetchMetaStorageAddrIntervalInMills") 
        
           private Integer eventMeshFetchMetaStorageAddrInterval = 10 * 1000;

Deprecate eventMesh.server.defibus.client.comsumeTimeoutInMin and 'defibus' related usages: These usages are commented and not used since EventMesh initiated, and may output one line of null log.
Place similar properties together and add a seperator.
I found out that I forgot to unify null != object in [ISSUE #4808] Unify all null == object usage to standard object == null #4809 when writting this PR (only null == object usages unified), so this PR contains supplements of the previous one.

Documentation

Does this pull request introduce a new feature? (no)

…stryAddrIntervalInMills`

codecov-commenter · 2024-04-14T14:06:01Z

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 16.18%. Comparing base (e04156b) to head (6c63240).
Report is 6 commits behind head on master.

❗ Current head 6c63240 differs from pull request most recent head c477f0d. Consider uploading reports for the commit c477f0d to get more accurate results

Files	Patch %	Lines
.../jdbc/source/dialect/cdc/mysql/MysqlCdcEngine.java	0.00%	3 Missing ⚠️
...time/core/protocol/tcp/client/session/Session.java	0.00%	3 Missing ⚠️
...pache/eventmesh/common/EventMeshThreadFactory.java	0.00%	0 Missing and 2 partials ⚠️
...ventmesh/connector/lark/sink/ImServiceHandler.java	0.00%	0 Missing and 2 partials ⚠️
...che/eventmesh/runtime/boot/AbstractHTTPServer.java	0.00%	2 Missing ⚠️
...ntmesh/storage/rabbitmq/client/RabbitmqClient.java	0.00%	0 Missing and 2 partials ⚠️
...r/jdbc/dialect/AbstractGeneralDatabaseDialect.java	0.00%	1 Missing ⚠️
...tlr4/mysql/listener/CreateTableParserListener.java	0.00%	1 Missing ⚠️
.../eventmesh/connector/jdbc/table/catalog/Table.java	0.00%	1 Missing ⚠️
...entmesh/meta/consul/service/ConsulMetaService.java	0.00%	0 Missing and 1 partial ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4839      +/-   ##
============================================
- Coverage     16.20%   16.18%   -0.03%     
+ Complexity     1710     1708       -2     
============================================
  Files           857      858       +1     
  Lines         30883    30863      -20     
  Branches       2685     2691       +6     
============================================
- Hits           5005     4994      -11     
+ Misses        25410    25400      -10     
- Partials        468      469       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mxsm

LGTM

* [ISSUE #4812] Set up Admin Endpoints v2 (#4813) * Remove redundant overloaded methods * Simplify write() result param * Add writeJson(); Add PUT; Add JavaDoc * Rename EventHttpHandler to EventMeshHttpHandler * Correct server thread name * Clean up messy & non-hierarchical overloading * No need to set headers manually any more * Set up v1&v2 endpoints * Set up v1&v2 response dto * Introduce fastjson2 * Fix fastjson2 "level too large : 2048" error caused by IPAddress * Correct @ConfigField naming * Return properties format json key * Add format option to query string * Introduce Result * Reduce duplicate builder code * Fix all checkstyle warnings in eventmesh-runtime * Add known dependency * [ISSUE #4814] Migrate from fastjson 1.2.83 to fastjson2 (#4819) * [Enhancement] Migrate from fastjson 1.2.83 to fastjson2 #4814 * fix_dependencies_problem * fix_check * [ISSUE #4551] modify the logic of time-consumption statistics (#4822) * init connector runtime v2 * [ISSUE #4804] Fix SubStreamHandler exception loop by closeOnError (#4807) * Handle exception loop by closeOnError * Lombok optimization * some format optimization * Avoid closing multiple times * Remove redundant set null * Revert "Avoid closing multiple times" This reverts commit 774397f. * Use synchronized latch to keep senderOnComplete called once * Use boolean to prevent latch called by somebody else * Remove the unique callee/caller close() of onCompleted() * [ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties (#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement #4809 for `null != object` * [ISSUE #4832] Downgrade stale bot to v8 to resolve state cache reserving error (#4833) * Revert stale bot to v8 to resolve state cache reserving error * Reduce operations-per-run to default value to ease pressure * Unify yaml to yml * [ISSUE #4820] Bug fix EventHandler not return json (#4821) * bug fix * bug fix * bug fix * update runtime v2 * update connector runtime * update connector runtime * update connector runtime * update connector runtime * update connector runtime --------- Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com>

* EventMesh function admin (#4851) * own * dependency * finish registry * EventMesh function admin (#4853) * own * dependency * finish registry * init * Eventmesh function admin (#4854) * own * dependency * finish registry * init * 0419 * 0419 * more discovery and move gRPC * fix dependency * EventMesh function connector runtime (#4858) * [ISSUE #4812] Set up Admin Endpoints v2 (#4813) * Remove redundant overloaded methods * Simplify write() result param * Add writeJson(); Add PUT; Add JavaDoc * Rename EventHttpHandler to EventMeshHttpHandler * Correct server thread name * Clean up messy & non-hierarchical overloading * No need to set headers manually any more * Set up v1&v2 endpoints * Set up v1&v2 response dto * Introduce fastjson2 * Fix fastjson2 "level too large : 2048" error caused by IPAddress * Correct @ConfigField naming * Return properties format json key * Add format option to query string * Introduce Result * Reduce duplicate builder code * Fix all checkstyle warnings in eventmesh-runtime * Add known dependency * [ISSUE #4814] Migrate from fastjson 1.2.83 to fastjson2 (#4819) * [Enhancement] Migrate from fastjson 1.2.83 to fastjson2 #4814 * fix_dependencies_problem * fix_check * [ISSUE #4551] modify the logic of time-consumption statistics (#4822) * init connector runtime v2 * [ISSUE #4804] Fix SubStreamHandler exception loop by closeOnError (#4807) * Handle exception loop by closeOnError * Lombok optimization * some format optimization * Avoid closing multiple times * Remove redundant set null * Revert "Avoid closing multiple times" This reverts commit 774397f. * Use synchronized latch to keep senderOnComplete called once * Use boolean to prevent latch called by somebody else * Remove the unique callee/caller close() of onCompleted() * [ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties (#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement #4809 for `null != object` * [ISSUE #4832] Downgrade stale bot to v8 to resolve state cache reserving error (#4833) * Revert stale bot to v8 to resolve state cache reserving error * Reduce operations-per-run to default value to ease pressure * Unify yaml to yml * [ISSUE #4820] Bug fix EventHandler not return json (#4821) * bug fix * bug fix * bug fix * update runtime v2 * update connector runtime * update connector runtime * update connector runtime * update connector runtime * update connector runtime --------- Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com> * [ISSUE #4931]Add Registry Module for Discovery AdminServer * [ISSUES #4933]Add Admin Module * [ISSUE #4935] Add and Move the Pojo Used By Both Runtime and Admin to Common * [ISSUE #4937]fix gradle dependecy and add runtime v2 * [ISSUES #4939]add canal connector * fix missing apache header * fix missing apache header * fix missing apache header * update gradle dependencies * fix admin server ci check error * fix admin server ci check error * fix ci checkStyle error * fix ci check error --------- Co-authored-by: sodaRyCN <35725024+sodaRyCN@users.noreply.github.com> Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com>

* EventMesh function admin (#4851) * own * dependency * finish registry * EventMesh function admin (#4853) * own * dependency * finish registry * init * Eventmesh function admin (#4854) * own * dependency * finish registry * init * 0419 * 0419 * more discovery and move gRPC * fix dependency * EventMesh function connector runtime (#4858) * [ISSUE #4812] Set up Admin Endpoints v2 (#4813) * Remove redundant overloaded methods * Simplify write() result param * Add writeJson(); Add PUT; Add JavaDoc * Rename EventHttpHandler to EventMeshHttpHandler * Correct server thread name * Clean up messy & non-hierarchical overloading * No need to set headers manually any more * Set up v1&v2 endpoints * Set up v1&v2 response dto * Introduce fastjson2 * Fix fastjson2 "level too large : 2048" error caused by IPAddress * Correct @ConfigField naming * Return properties format json key * Add format option to query string * Introduce Result * Reduce duplicate builder code * Fix all checkstyle warnings in eventmesh-runtime * Add known dependency * [ISSUE #4814] Migrate from fastjson 1.2.83 to fastjson2 (#4819) * [Enhancement] Migrate from fastjson 1.2.83 to fastjson2 #4814 * fix_dependencies_problem * fix_check * [ISSUE #4551] modify the logic of time-consumption statistics (#4822) * init connector runtime v2 * [ISSUE #4804] Fix SubStreamHandler exception loop by closeOnError (#4807) * Handle exception loop by closeOnError * Lombok optimization * some format optimization * Avoid closing multiple times * Remove redundant set null * Revert "Avoid closing multiple times" This reverts commit 774397f. * Use synchronized latch to keep senderOnComplete called once * Use boolean to prevent latch called by somebody else * Remove the unique callee/caller close() of onCompleted() * [ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties (#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement #4809 for `null != object` * [ISSUE #4832] Downgrade stale bot to v8 to resolve state cache reserving error (#4833) * Revert stale bot to v8 to resolve state cache reserving error * Reduce operations-per-run to default value to ease pressure * Unify yaml to yml * [ISSUE #4820] Bug fix EventHandler not return json (#4821) * bug fix * bug fix * bug fix * update runtime v2 * update connector runtime * update connector runtime * update connector runtime * update connector runtime * update connector runtime --------- Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com> * [ISSUE #4931]Add Registry Module for Discovery AdminServer * [ISSUES #4933]Add Admin Module * [ISSUE #4935] Add and Move the Pojo Used By Both Runtime and Admin to Common * [ISSUE #4937]fix gradle dependecy and add runtime v2 * [ISSUES #4939]add canal connector * fix missing apache header * fix missing apache header * fix missing apache header * update gradle dependencies * fix admin server ci check error * fix admin server ci check error * fix ci checkStyle error * fix ci check error * [ISSUE #4979]Canal Connector supports bidirectional data synchronization * add bash files for admin & runtime-v2 * fix ack offset read & persist * fix checkStyle error * [ISSUE #4979] Canal Connector supports bidirectional data synchronization (#5011) * [ISSUE #4979]Canal Connector supports bidirectional data synchronization * add bash files for admin & runtime-v2 * fix ack offset read & persist * fix checkStyle error * fix http source connector test error --------- Co-authored-by: sodaRyCN <35725024+sodaRyCN@users.noreply.github.com> Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com>

* [ISSUE #4812] Set up Admin Endpoints v2 (#4813) * Remove redundant overloaded methods * Simplify write() result param * Add writeJson(); Add PUT; Add JavaDoc * Rename EventHttpHandler to EventMeshHttpHandler * Correct server thread name * Clean up messy & non-hierarchical overloading * No need to set headers manually any more * Set up v1&v2 endpoints * Set up v1&v2 response dto * Introduce fastjson2 * Fix fastjson2 "level too large : 2048" error caused by IPAddress * Correct @ConfigField naming * Return properties format json key * Add format option to query string * Introduce Result * Reduce duplicate builder code * Fix all checkstyle warnings in eventmesh-runtime * Add known dependency * [ISSUE #4814] Migrate from fastjson 1.2.83 to fastjson2 (#4819) * [Enhancement] Migrate from fastjson 1.2.83 to fastjson2 #4814 * fix_dependencies_problem * fix_check * [ISSUE #4551] modify the logic of time-consumption statistics (#4822) * init connector runtime v2 * [ISSUE #4804] Fix SubStreamHandler exception loop by closeOnError (#4807) * Handle exception loop by closeOnError * Lombok optimization * some format optimization * Avoid closing multiple times * Remove redundant set null * Revert "Avoid closing multiple times" This reverts commit 767bc59. * Use synchronized latch to keep senderOnComplete called once * Use boolean to prevent latch called by somebody else * Remove the unique callee/caller close() of onCompleted() * [ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties (#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement #4809 for `null != object` * [ISSUE #4832] Downgrade stale bot to v8 to resolve state cache reserving error (#4833) * Revert stale bot to v8 to resolve state cache reserving error * Reduce operations-per-run to default value to ease pressure * Unify yaml to yml * [ISSUE #4820] Bug fix EventHandler not return json (#4821) * bug fix * bug fix * bug fix * update runtime v2 * update connector runtime * update connector runtime * update connector runtime * update connector runtime * update connector runtime --------- Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com>

…` etc. properties (apache#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement apache#4809 for `null != object`

* EventMesh function admin (apache#4851) * own * dependency * finish registry * EventMesh function admin (apache#4853) * own * dependency * finish registry * init * Eventmesh function admin (apache#4854) * own * dependency * finish registry * init * 0419 * 0419 * more discovery and move gRPC * fix dependency * EventMesh function connector runtime (apache#4858) * [ISSUE apache#4812] Set up Admin Endpoints v2 (apache#4813) * Remove redundant overloaded methods * Simplify write() result param * Add writeJson(); Add PUT; Add JavaDoc * Rename EventHttpHandler to EventMeshHttpHandler * Correct server thread name * Clean up messy & non-hierarchical overloading * No need to set headers manually any more * Set up v1&v2 endpoints * Set up v1&v2 response dto * Introduce fastjson2 * Fix fastjson2 "level too large : 2048" error caused by IPAddress * Correct @ConfigField naming * Return properties format json key * Add format option to query string * Introduce Result * Reduce duplicate builder code * Fix all checkstyle warnings in eventmesh-runtime * Add known dependency * [ISSUE apache#4814] Migrate from fastjson 1.2.83 to fastjson2 (apache#4819) * [Enhancement] Migrate from fastjson 1.2.83 to fastjson2 apache#4814 * fix_dependencies_problem * fix_check * [ISSUE apache#4551] modify the logic of time-consumption statistics (apache#4822) * init connector runtime v2 * [ISSUE apache#4804] Fix SubStreamHandler exception loop by closeOnError (apache#4807) * Handle exception loop by closeOnError * Lombok optimization * some format optimization * Avoid closing multiple times * Remove redundant set null * Revert "Avoid closing multiple times" This reverts commit 767bc59. * Use synchronized latch to keep senderOnComplete called once * Use boolean to prevent latch called by somebody else * Remove the unique callee/caller close() of onCompleted() * [ISSUE apache#4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties (apache#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement apache#4809 for `null != object` * [ISSUE apache#4832] Downgrade stale bot to v8 to resolve state cache reserving error (apache#4833) * Revert stale bot to v8 to resolve state cache reserving error * Reduce operations-per-run to default value to ease pressure * Unify yaml to yml * [ISSUE apache#4820] Bug fix EventHandler not return json (apache#4821) * bug fix * bug fix * bug fix * update runtime v2 * update connector runtime * update connector runtime * update connector runtime * update connector runtime * update connector runtime --------- Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com> * [ISSUE apache#4931]Add Registry Module for Discovery AdminServer * [ISSUES apache#4933]Add Admin Module * [ISSUE apache#4935] Add and Move the Pojo Used By Both Runtime and Admin to Common * [ISSUE apache#4937]fix gradle dependecy and add runtime v2 * [ISSUES apache#4939]add canal connector * fix missing apache header * fix missing apache header * fix missing apache header * update gradle dependencies * fix admin server ci check error * fix admin server ci check error * fix ci checkStyle error * fix ci check error --------- Co-authored-by: sodaRyCN <35725024+sodaRyCN@users.noreply.github.com> Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com>

* EventMesh function admin (apache#4851) * own * dependency * finish registry * EventMesh function admin (apache#4853) * own * dependency * finish registry * init * Eventmesh function admin (apache#4854) * own * dependency * finish registry * init * 0419 * 0419 * more discovery and move gRPC * fix dependency * EventMesh function connector runtime (apache#4858) * [ISSUE apache#4812] Set up Admin Endpoints v2 (apache#4813) * Remove redundant overloaded methods * Simplify write() result param * Add writeJson(); Add PUT; Add JavaDoc * Rename EventHttpHandler to EventMeshHttpHandler * Correct server thread name * Clean up messy & non-hierarchical overloading * No need to set headers manually any more * Set up v1&v2 endpoints * Set up v1&v2 response dto * Introduce fastjson2 * Fix fastjson2 "level too large : 2048" error caused by IPAddress * Correct @ConfigField naming * Return properties format json key * Add format option to query string * Introduce Result * Reduce duplicate builder code * Fix all checkstyle warnings in eventmesh-runtime * Add known dependency * [ISSUE apache#4814] Migrate from fastjson 1.2.83 to fastjson2 (apache#4819) * [Enhancement] Migrate from fastjson 1.2.83 to fastjson2 apache#4814 * fix_dependencies_problem * fix_check * [ISSUE apache#4551] modify the logic of time-consumption statistics (apache#4822) * init connector runtime v2 * [ISSUE apache#4804] Fix SubStreamHandler exception loop by closeOnError (apache#4807) * Handle exception loop by closeOnError * Lombok optimization * some format optimization * Avoid closing multiple times * Remove redundant set null * Revert "Avoid closing multiple times" This reverts commit 767bc59. * Use synchronized latch to keep senderOnComplete called once * Use boolean to prevent latch called by somebody else * Remove the unique callee/caller close() of onCompleted() * [ISSUE apache#4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties (apache#4839) * Remove all references of `eventMesh.connector.plugin.type` * Deprecate `eventMesh.connector.plugin.type` and sort properties * Remove misconfigured & not-used `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills` * Remove 'defibus' related un-used usages * Supplement apache#4809 for `null != object` * [ISSUE apache#4832] Downgrade stale bot to v8 to resolve state cache reserving error (apache#4833) * Revert stale bot to v8 to resolve state cache reserving error * Reduce operations-per-run to default value to ease pressure * Unify yaml to yml * [ISSUE apache#4820] Bug fix EventHandler not return json (apache#4821) * bug fix * bug fix * bug fix * update runtime v2 * update connector runtime * update connector runtime * update connector runtime * update connector runtime * update connector runtime --------- Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com> * [ISSUE apache#4931]Add Registry Module for Discovery AdminServer * [ISSUES apache#4933]Add Admin Module * [ISSUE apache#4935] Add and Move the Pojo Used By Both Runtime and Admin to Common * [ISSUE apache#4937]fix gradle dependecy and add runtime v2 * [ISSUES apache#4939]add canal connector * fix missing apache header * fix missing apache header * fix missing apache header * update gradle dependencies * fix admin server ci check error * fix admin server ci check error * fix ci checkStyle error * fix ci check error * [ISSUE apache#4979]Canal Connector supports bidirectional data synchronization * add bash files for admin & runtime-v2 * fix ack offset read & persist * fix checkStyle error * [ISSUE apache#4979] Canal Connector supports bidirectional data synchronization (apache#5011) * [ISSUE apache#4979]Canal Connector supports bidirectional data synchronization * add bash files for admin & runtime-v2 * fix ack offset read & persist * fix checkStyle error * fix http source connector test error --------- Co-authored-by: sodaRyCN <35725024+sodaRyCN@users.noreply.github.com> Co-authored-by: Pil0tXia <xiatian@apache.org> Co-authored-by: Zaki <91261012+cnzakii@users.noreply.github.com> Co-authored-by: Karson <karsontao@hotmail.com>

Pil0tXia added 5 commits April 14, 2024 19:42

Remove all references of eventMesh.connector.plugin.type

d58ac85

Deprecate eventMesh.connector.plugin.type and sort properties

9c3abe0

Remove misconfigured & not-used registerIntervalInMills, `fetchRegi…

a027e86

…stryAddrIntervalInMills`

Remove 'defibus' related un-used usages

0b1050a

Supplement apache#4809 for null != object

c477f0d

mxsm approved these changes Apr 14, 2024

View reviewed changes

xwm1992 approved these changes Apr 15, 2024

View reviewed changes

xwm1992 merged commit 229201c into apache:master Apr 15, 2024

Pil0tXia deleted the pil0txia/deprecate_4838 branch April 15, 2024 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties#4839

[ISSUE #4838] Deprecate unused `eventMesh.connector.plugin.type` etc. properties#4839
xwm1992 merged 5 commits intoapache:masterfrom
Pil0tXia:pil0txia/deprecate_4838

Pil0tXia commented Apr 14, 2024 •

edited

Loading

Uh oh!

codecov-commenter commented Apr 14, 2024

Uh oh!

mxsm left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	eventMesh.server.metaStorage.metaStorageIntervalInMills=10000
	eventMesh.server.metaStorage.fetchMetaStorageAddrIntervalInMills=20000

	@ConfigField(field = "metaStorage.plugin.metaStorageIntervalInMills")
	private Integer eventMeshMetaStorageIntervalInMills = 10 * 1000;

	@ConfigField(field = "metaStorage.plugin.fetchMetaStorageAddrIntervalInMills")
	private Integer eventMeshFetchMetaStorageAddrInterval = 10 * 1000;

Conversation

Pil0tXia commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Modifications

Documentation

Uh oh!

codecov-commenter commented Apr 14, 2024

Codecov Report

Uh oh!

mxsm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Pil0tXia commented Apr 14, 2024 •

edited

Loading