Skip to content

[ISSUE #4633] Optimize the message body of the Rust SDK's returned reply message #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xwm1992 merged 2 commits into from
Jan 26, 2024
Merged

[ISSUE #4633] Optimize the message body of the Rust SDK's returned reply message #4751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54aec0
optimized returned reply msg
kyooosukedn Jan 19, 2024
96d208a
corrected the change
kyooosukedn Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions eventmesh-sdks/eventmesh-sdk-rust/src/grpc/grpc_consumer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,17 +146,6 @@ impl EventMeshGrpcConsumer {
let handled_msg = listener_inner.handle(eventmesh_message.unwrap());
if let Ok(msg_option) = handled_msg {
if let Some(_msg) = msg_option {
let properties = HashMap::<String, String>::new();
let reply = SubscriptionReply::new(
EventMeshCloudEventUtils::get_subject(&received),
EventMeshCloudEventUtils::get_subject(&received),
EventMeshCloudEventUtils::get_data_content(&received),
EventMeshCloudEventUtils::get_seq_num(&received),
EventMeshCloudEventUtils::get_unique_id(&received),
EventMeshCloudEventUtils::get_ttl(&received),
None,
properties,
);
received.attributes.insert(
ProtocolKey::SUB_MESSAGE_TYPE.to_string(),
PbCloudEventAttributeValue {
Expand All @@ -165,8 +154,7 @@ impl EventMeshGrpcConsumer {
)),
},
);
received.data =
Some(PbData::TextData(serde_json::to_string(&reply).unwrap()));
received.data = None;
let _ = keeper.sender.send(received).await;
}
} else {
Expand Down